Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594733005: Cleanup: Remove src/trusted/gio/, since it is unused (Closed)

Created:
6 years, 3 months ago by Mark Seaborn
Modified:
6 years, 2 months ago
Reviewers:
bradn, Roland McGrath
CC:
native-client-reviews_googlegroups.com
Project:
nacl
Visibility:
Public.

Description

Cleanup: Remove src/trusted/gio/, since it is unused GioShm has been unused since r11473 (from June 2013), when nexe loading was converted to using NaClDescs instead of Gio. BUG=none TEST=build Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=13789

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2219 lines) Patch
M SConstruct View 1 chunk +0 lines, -1 line 0 comments Download
M site_scons/site_tools/library_deps.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D src/trusted/gio/BUILD.gn View 1 chunk +0 lines, -13 lines 0 comments Download
D src/trusted/gio/build.scons View 1 chunk +0 lines, -83 lines 0 comments Download
D src/trusted/gio/gio_nacl_desc.h View 1 chunk +0 lines, -34 lines 0 comments Download
D src/trusted/gio/gio_nacl_desc.c View 1 chunk +0 lines, -83 lines 0 comments Download
D src/trusted/gio/gio_nacl_desc_test.c View 1 chunk +0 lines, -285 lines 0 comments Download
D src/trusted/gio/gio_shm.h View 1 chunk +0 lines, -61 lines 0 comments Download
D src/trusted/gio/gio_shm.c View 1 chunk +0 lines, -448 lines 0 comments Download
D src/trusted/gio/gio_shm_test.c View 1 chunk +0 lines, -449 lines 0 comments Download
D src/trusted/gio/gio_shm_unbounded.h View 1 chunk +0 lines, -56 lines 0 comments Download
D src/trusted/gio/gio_shm_unbounded.c View 1 chunk +0 lines, -334 lines 0 comments Download
D src/trusted/gio/gio_shm_unbounded_test.c View 1 chunk +0 lines, -202 lines 0 comments Download
D src/trusted/gio/gio_wrapped_desc.gyp View 1 chunk +0 lines, -70 lines 0 comments Download
D src/trusted/gio/gio_wrapped_desc_tests.gyp View 1 chunk +0 lines, -80 lines 0 comments Download
D src/trusted/gio/testdata/some_binary_file View Binary file 0 comments Download
M src/trusted/service_runtime/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/build.scons View 1 8 chunks +1 line, -10 lines 0 comments Download
M src/trusted/service_runtime/sel_ldr.c View 1 chunk +0 lines, -2 lines 0 comments Download
M src/trusted/service_runtime/sel_main_chrome.c View 1 chunk +0 lines, -1 line 0 comments Download
M src/trusted/service_runtime/service_runtime.gyp View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Mark Seaborn
6 years, 2 months ago (2014-09-25 15:24:40 UTC) #2
Roland McGrath
lgtm
6 years, 2 months ago (2014-09-25 17:46:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594733005/20001
6 years, 2 months ago (2014-09-25 17:49:10 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 13789
6 years, 2 months ago (2014-09-25 20:11:26 UTC) #6
bradn
6 years, 2 months ago (2014-09-25 21:08:18 UTC) #7
Message was sent while issue was closed. 
Cool, I missed when this stopped being used.
LGTM!

Powered by Google App Engine
This is Rietveld 408576698