Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs

Issue 594733002: [VS Addin] Add default compiler include paths to visual studio (Closed) Base URL: https://nativeclient-sdk.googlecode.com/svn/trunk/src
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs
diff --git a/visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs b/visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs
index d8a4b453fd3e2271a520d24e5625ee5545b34e0e..0aa2a74e020f2237c379d47434775d6d0452f815 100644
--- a/visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs
+++ b/visual_studio/NativeClientVSAddIn/UnitTests/PropertyManagerTest.cs
@@ -201,7 +201,6 @@ namespace UnitTests
string slnDir = Path.GetDirectoryName(naclSolution);
string projectDir = Path.Combine(
slnDir, Path.GetDirectoryName(TestUtilities.NaClProjectUniqueName)) + @"\";
-
foreach (string platform in NaClPlatformNames())
{
@@ -237,39 +236,6 @@ namespace UnitTests
}
/// <summary>
- /// A test for GetProperty. Checks some non-trivial C# properties and the GetProperty method.
- /// </summary>
- [TestMethod]
- public void GetPropertyPNaClTest()
- {
- string expectedSDKRootDir =
- Environment.GetEnvironmentVariable(Strings.SDKPathEnvironmentVariable);
- Assert.IsNotNull(expectedSDKRootDir, "SDK Path environment variable not set!");
- expectedSDKRootDir = expectedSDKRootDir.TrimEnd(new char[] { '/', '\\' });
-
- // Set up the property manager to read the NaCl platform settings from BlankValidSolution.
- PropertyManager target = new PropertyManager();
- dte_.Solution.Open(naclSolution);
- Project naclProject = dte_.Solution.Projects.Item(TestUtilities.NaClProjectUniqueName);
- target.SetTarget(naclProject, Strings.PNaClPlatformName, "Debug");
- Assert.AreEqual(
- PropertyManager.ProjectPlatformType.NaCl,
- target.PlatformType,
- "SetTarget did not succeed with nacl platform on valid project.");
-
- string slnDir = Path.GetDirectoryName(naclSolution);
- string projectDir = Path.Combine(
- slnDir, Path.GetDirectoryName(TestUtilities.NaClProjectUniqueName)) + @"\";
- string outputDir = Path.Combine(projectDir, "PNaCl", "newlib", "Debug") + @"\";
- string assembly = Path.Combine(outputDir, TestUtilities.BlankNaClProjectName + ".pexe");
-
- Assert.AreEqual(expectedSDKRootDir, target.SDKRootDirectory, "SDK Root.");
- Assert.AreEqual(projectDir, target.ProjectDirectory, "ProjectDirectory.");
- Assert.AreEqual(outputDir, target.OutputDirectory, "OutputDirectory.");
- Assert.AreEqual(assembly, target.PluginAssembly, "PluginAssembly.");
- }
-
- /// <summary>
/// Return a list of all nacl platform names.
/// </summary>
public static string[] NaClPlatformNames()

Powered by Google App Engine
This is Rietveld 408576698