Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issue 594733002: [VS Addin] Add default compiler include paths to visual studio (Closed)

Created:
6 years, 3 months ago by Sam Clegg
Modified:
6 years, 2 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

[VS Addin] Add default compiler include paths to visual studio This allows intelisense to find the NaCl compiler headers and prevents the red underline on standard include files. Still not perfect as it doesn't dectect use of libc++ vs libstdc++ in PNaCl, but a huge improvement. I ended up forking the default.props files (previously these were derived from the x86_64 version at package create time). TEST= manual local testing. BUG= https://code.google.com/p/chromium/issues/detail?id=179121 R=binji@chromium.org Committed: https://code.google.com/p/nativeclient-sdk/source/detail?r=1578

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages

Total messages: 5 (1 generated)
Sam Clegg
6 years, 3 months ago (2014-09-23 01:10:18 UTC) #2
binji
lgtm
6 years, 3 months ago (2014-09-23 20:30:17 UTC) #3
Sam Clegg
Committed patchset #3 manually as r1578 (presubmit successful).
6 years, 2 months ago (2014-09-24 18:54:52 UTC) #4
nkanand
6 years, 2 months ago (2014-10-10 19:27:55 UTC) #5
Message was sent while issue was closed.
On 2014/09/24 18:54:52, Sam Clegg wrote:
> Committed patchset #3 manually as r1578 (presubmit successful).

Now the builds are failing with error message:
...nacl_sdk\pepper_37\toolchain\win_x86_newlib\bin\x86_32-nacl-gcc.exe is
invalid.
Changes in pepper bundle to include the compiler and linker exe's for Nacl32 are
missing

Powered by Google App Engine
This is Rietveld 408576698