Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9709)

Unified Diff: content/renderer/media/android/webmediaplayer_android.cc

Issue 594713002: Pass initial CDM to CreateMediaPlayer() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fixes for android + mojo Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/android/webmediaplayer_android.cc
diff --git a/content/renderer/media/android/webmediaplayer_android.cc b/content/renderer/media/android/webmediaplayer_android.cc
index 53accf2814e0b1e73ea8928d77636504ad6a8cfe..ea6ba1f0d538dcbb96d046e39c9af674aca353da 100644
--- a/content/renderer/media/android/webmediaplayer_android.cc
+++ b/content/renderer/media/android/webmediaplayer_android.cc
@@ -115,6 +115,7 @@ WebMediaPlayerAndroid::WebMediaPlayerAndroid(
base::WeakPtr<media::WebMediaPlayerDelegate> delegate,
RendererMediaPlayerManager* player_manager,
RendererCdmManager* cdm_manager,
+ blink::WebContentDecryptionModule* initial_cdm,
scoped_refptr<StreamTextureFactory> factory,
const scoped_refptr<base::SingleThreadTaskRunner>& task_runner,
media::MediaLog* media_log)
@@ -173,6 +174,13 @@ WebMediaPlayerAndroid::WebMediaPlayerAndroid(
#endif // defined(VIDEO_HOLE)
TryCreateStreamTextureProxyIfNeeded();
interpolator_.SetUpperBound(base::TimeDelta());
+
+ // Set the initial CDM, if specified.
+ if (initial_cdm) {
+ web_cdm_ = ToWebContentDecryptionModuleImpl(initial_cdm);
+ if (web_cdm_->GetCdmId() != RendererCdmManager::kInvalidCdmId)
+ player_manager_->SetCdm(player_id_, web_cdm_->GetCdmId());
+ }
}
WebMediaPlayerAndroid::~WebMediaPlayerAndroid() {
@@ -1674,21 +1682,6 @@ void WebMediaPlayerAndroid::setContentDecryptionModule(
player_manager_->SetCdm(player_id_, web_cdm_->GetCdmId());
}
-void WebMediaPlayerAndroid::setContentDecryptionModuleSync(
- blink::WebContentDecryptionModule* cdm) {
- DCHECK(main_thread_checker_.CalledOnValidThread());
-
- // TODO(xhwang): Support setMediaKeys(0) if necessary: http://crbug.com/330324
- if (!cdm)
- return;
-
- DCHECK(decryptor_ready_cb_.is_null());
-
- web_cdm_ = ToWebContentDecryptionModuleImpl(cdm);
- if (web_cdm_->GetCdmId() != RendererCdmManager::kInvalidCdmId)
- player_manager_->SetCdm(player_id_, web_cdm_->GetCdmId());
-}
-
void WebMediaPlayerAndroid::ContentDecryptionModuleAttached(
blink::WebContentDecryptionModuleResult result,
bool success) {

Powered by Google App Engine
This is Rietveld 408576698