Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 594673002: Remove incorrect promise resolving type handling. (Closed)

Created:
6 years, 3 months ago by xhwang
Modified:
6 years, 2 months ago
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove incorrect promise resolving type handling. This partially reverts commit fd0069d61b1f3281a2634bf907a96bebee7fb396. Issue 408330 has been fixed with a CDM update. This error handling code is not needed anymore. BUG=408337

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -13 lines) Patch
M content/renderer/pepper/content_decryptor_delegate.cc View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
xhwang
PTAL
6 years, 3 months ago (2014-09-22 22:07:27 UTC) #2
jrummell
lgtm. Will M39 have to work with versions of the CDM that don't have the ...
6 years, 3 months ago (2014-09-22 22:10:27 UTC) #3
xhwang
ddorwin: kindly ping....
6 years, 2 months ago (2014-09-26 18:21:21 UTC) #4
ddorwin
lgtm
6 years, 2 months ago (2014-09-26 18:50:07 UTC) #5
xhwang
TBRing dmichael@chromium.org since this is only a cleanup CL that removes some hack.
6 years, 2 months ago (2014-09-26 18:55:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594673002/1
6 years, 2 months ago (2014-09-26 18:55:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as 1384d564d0a773bbd242d23c2edd753f86683fc9
6 years, 2 months ago (2014-09-26 19:41:06 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/9ee0c035ce3e9dffbf17edf79f4f68711881d0a5 Cr-Commit-Position: refs/heads/master@{#297008}
6 years, 2 months ago (2014-09-26 19:42:09 UTC) #12
dmichael (off chromium)
6 years, 2 months ago (2014-10-01 21:24:50 UTC) #14
lgtm

Powered by Google App Engine
This is Rietveld 408576698