Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 594653004: [GN build] Add a BUILD.gn file for //third_party/decklink (Closed)

Created:
6 years, 3 months ago by Ilya Sherman
Modified:
6 years, 2 months ago
Reviewers:
perkj_chrome, jamesr
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[GN build] Add a BUILD.gn file for //third_party/decklink BUG=none TEST=none R=jamesr@chromium.org TBR=perkj@chromium.org NOPRESUBMIT=true NOTRY=true Committed: https://crrev.com/8652b92e1a0fbb6716c5b482f38de4ebc8b11157 Cr-Commit-Position: refs/heads/master@{#296141}

Patch Set 1 #

Patch Set 2 : Similarity: 100% #

Total comments: 1

Patch Set 3 : Add cross-references #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
A + third_party/decklink/BUILD.gn View 1 2 1 chunk +6 lines, -7 lines 0 comments Download
M third_party/decklink/decklink.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ilya Sherman
6 years, 3 months ago (2014-09-23 00:56:12 UTC) #1
jamesr
lgtm https://codereview.chromium.org/594653004/diff/20001/third_party/decklink/BUILD.gn File third_party/decklink/BUILD.gn (right): https://codereview.chromium.org/594653004/diff/20001/third_party/decklink/BUILD.gn#newcode6 third_party/decklink/BUILD.gn:6: static_library("decklink") { can you please add a reference ...
6 years, 3 months ago (2014-09-23 04:08:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594653004/40001
6 years, 3 months ago (2014-09-23 04:45:22 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as f20f8b3058c6517c481be8b1012b8c4d681d91f6
6 years, 3 months ago (2014-09-23 04:45:48 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 04:46:24 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8652b92e1a0fbb6716c5b482f38de4ebc8b11157
Cr-Commit-Position: refs/heads/master@{#296141}

Powered by Google App Engine
This is Rietveld 408576698