Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 594653003: Move web_request_internal_custom_bindings.js and web_request_custom_bindings.js (Closed)

Created:
6 years, 3 months ago by Xi Han
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, wjmaclean, lfg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move web_request_internal_custom_bindings.js and web_request_custom_bindings.js to //extensions. BUG=352293 Committed: https://crrev.com/8ff718bbef88fcdc4de31f7cbd1325dff589ea32 Cr-Commit-Position: refs/heads/master@{#296289}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove HandleWebRequestAPIUsage from dispatcher_delegate. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -241 lines) Patch
M chrome/chrome_renderer.gypi View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.cc View 3 chunks +1 line, -10 lines 0 comments Download
D chrome/renderer/resources/extensions/web_request_custom_bindings.js View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/renderer/resources/extensions/web_request_internal_custom_bindings.js View 1 chunk +0 lines, -192 lines 0 comments Download
M chrome/renderer/resources/renderer_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
M extensions/extensions.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.h View 1 2 chunks +5 lines, -0 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher_delegate.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/renderer/resources/extensions_renderer_resources.grd View 1 chunk +3 lines, -1 line 0 comments Download
A + extensions/renderer/resources/web_request_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + extensions/renderer/resources/web_request_internal_custom_bindings.js View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Xi Han
6 years, 3 months ago (2014-09-22 21:23:52 UTC) #2
Fady Samuel
lgtm
6 years, 3 months ago (2014-09-22 21:35:11 UTC) #3
Xi Han
rockot@chromium.org: Please review all changes. Thanks!
6 years, 3 months ago (2014-09-22 21:37:06 UTC) #5
Ken Rockot(use gerrit already)
lgtm but please see my inline comment about the delegate https://codereview.chromium.org/594653003/diff/1/extensions/renderer/dispatcher_delegate.h File extensions/renderer/dispatcher_delegate.h (right): https://codereview.chromium.org/594653003/diff/1/extensions/renderer/dispatcher_delegate.h#newcode90 ...
6 years, 3 months ago (2014-09-22 21:44:55 UTC) #6
Xi Han
jochen@chromium.org: Please review changes in: -chrome/renderer/chrome_content_renderer_client.cc -chrome/renderer/resources/renderer_resources.grd https://codereview.chromium.org/594653003/diff/1/extensions/renderer/dispatcher_delegate.h File extensions/renderer/dispatcher_delegate.h (right): https://codereview.chromium.org/594653003/diff/1/extensions/renderer/dispatcher_delegate.h#newcode90 extensions/renderer/dispatcher_delegate.h:90: virtual void ...
6 years, 3 months ago (2014-09-23 14:03:56 UTC) #8
Xi Han
+sky@chromium.org: Please review changes in: -chrome/renderer/chrome_content_renderer_client.cc -chrome/renderer/resources/renderer_resources.grd Thanks a lot!
6 years, 3 months ago (2014-09-23 17:04:22 UTC) #10
sky
Said files LGTM
6 years, 3 months ago (2014-09-23 22:24:53 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594653003/20001
6 years, 3 months ago (2014-09-23 22:42:02 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4623758b4c22dece29c9ecf0314a95cb611b1068
6 years, 3 months ago (2014-09-23 22:48:27 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:49:05 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8ff718bbef88fcdc4de31f7cbd1325dff589ea32
Cr-Commit-Position: refs/heads/master@{#296289}

Powered by Google App Engine
This is Rietveld 408576698