Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: chrome/browser/sync/glue/device_info.h

Issue 594643003: Device info datatype should be moved to components/sync_driver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed CR feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/device_info.h
diff --git a/chrome/browser/sync/glue/device_info.h b/chrome/browser/sync/glue/device_info.h
index a46e6508799a63c683522196d0633c96b3cd6c04..3faf6689442f694ff0abd1fdcc8a2c7d90b2ef66 100644
--- a/chrome/browser/sync/glue/device_info.h
+++ b/chrome/browser/sync/glue/device_info.h
@@ -8,22 +8,20 @@
#include <string>
#include "base/basictypes.h"
-#include "base/bind.h"
+#include "base/callback.h"
#include "sync/protocol/sync.pb.h"
namespace base {
class DictionaryValue;
}
-namespace chrome {
-class VersionInfo;
-}
-
namespace browser_sync {
// A class that holds information regarding the properties of a device.
class DeviceInfo {
public:
+ typedef base::Callback<void(const std::string&)> GetClientNameCallback;
+
DeviceInfo(const std::string& guid,
const std::string& client_name,
const std::string& chrome_version,
@@ -46,7 +44,7 @@ class DeviceInfo {
// The user agent is the combination of OS type, chrome version and which
// channel of chrome(stable or beta). For more information see
- // |DeviceInfo::MakeUserAgentForSyncApi|.
+ // |LocalDeviceInfoProviderImpl::MakeUserAgentForSyncApi|.
const std::string& sync_user_agent() const;
// Third party visible id for the device. See |public_id_| for more details.
@@ -78,36 +76,10 @@ class DeviceInfo {
// which extension APIs can expose to third party apps.
base::DictionaryValue* ToValue();
- static sync_pb::SyncEnums::DeviceType GetLocalDeviceType();
-
- // Creates a |DeviceInfo| object representing the local device and passes
- // it as parameter to the callback.
- static void CreateLocalDeviceInfo(
- const std::string& guid,
- const std::string& signin_scoped_device_id,
- base::Callback<void(const DeviceInfo& local_info)> callback);
-
// Gets the local device name and passes it as a parameter to callback.
- static void GetClientName(
- base::Callback<void(const std::string& local_info)> callback);
-
- // Helper to construct a user agent string (ASCII) suitable for use by
- // the syncapi for any HTTP communication. This string is used by the sync
- // backend for classifying client types when calculating statistics.
- static std::string MakeUserAgentForSyncApi(
- const chrome::VersionInfo& version_info);
+ static void GetClientName(const GetClientNameCallback& callback);
private:
- static void GetClientNameContinuation(
- base::Callback<void(const std::string& local_info)> callback,
- const std::string& session_name);
-
- static void CreateLocalDeviceInfoContinuation(
- const std::string& guid,
- const std::string& signin_scoped_device_id,
- base::Callback<void(const DeviceInfo& local_info)> callback,
- const std::string& session_name);
-
const std::string guid_;
const std::string client_name_;
« no previous file with comments | « chrome/browser/search_engines/ui_thread_search_terms_data.cc ('k') | chrome/browser/sync/glue/device_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698