Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: chrome/browser/sync/glue/local_device_info_provider_impl.h

Issue 594643003: Device info datatype should be moved to components/sync_driver. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed dependencies in ui_thread_search_terms_data.cc Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/local_device_info_provider_impl.h
diff --git a/chrome/browser/sync/glue/local_device_info_provider_impl.h b/chrome/browser/sync/glue/local_device_info_provider_impl.h
index 752a663633009f81c92d0ba52ae79e71e7c3fc79..2b71cd2aa13dddcdb6bf9378b936baa7055620c2 100644
--- a/chrome/browser/sync/glue/local_device_info_provider_impl.h
+++ b/chrome/browser/sync/glue/local_device_info_provider_impl.h
@@ -9,6 +9,10 @@
#include "chrome/browser/sync/glue/device_info.h"
#include "chrome/browser/sync/glue/local_device_info_provider.h"
+namespace chrome {
+class VersionInfo;
+}
+
namespace browser_sync {
class LocalDeviceInfoProviderImpl : public LocalDeviceInfoProvider {
@@ -25,8 +29,16 @@ class LocalDeviceInfoProviderImpl : public LocalDeviceInfoProvider {
virtual scoped_ptr<Subscription> RegisterOnInitializedCallback(
const base::Closure& callback) OVERRIDE;
+ // Helper to construct a user agent string (ASCII) suitable for use by
+ // the syncapi for any HTTP communication. This string is used by the sync
+ // backend for classifying client types when calculating statistics.
+ static std::string MakeUserAgentForSyncApi(
+ const chrome::VersionInfo& version_info);
+
private:
- void InitializeContinuation(const DeviceInfo& local_info);
+ void InitializeContinuation(const std::string& guid,
+ const std::string& signin_scoped_device_id,
+ const std::string& session_name);
std::string cache_guid_;
scoped_ptr<DeviceInfo> local_device_info_;

Powered by Google App Engine
This is Rietveld 408576698