Source/core/html/HTMLInputElement.cpp - Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLInputElement.cpp

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add extra assertion Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLInputElement.cpp

diff --git a/Source/core/html/HTMLInputElement.cpp b/Source/core/html/HTMLInputElement.cpp

index b6b46f7d71c4924503cca79ec8942df4809136c7..2c4c8e6aa69730f5952edf34b18936eb511d198b 100644

--- a/Source/core/html/HTMLInputElement.cpp

+++ b/Source/core/html/HTMLInputElement.cpp

@@ -141,7 +141,7 @@ HTMLImageLoader* HTMLInputElement::imageLoader()

return m_imageLoader.get();

}

-void HTMLInputElement::didAddUserAgentShadowRoot(ShadowRoot*)

+void HTMLInputElement::didAddUserAgentShadowRoot(ShadowRoot&)

{

m_inputType->createShadowSubtree();

}

« no previous file with comments | « Source/core/html/HTMLInputElement.h ('k') | Source/core/html/HTMLKeygenElement.h » ('j') | no next file with comments »