Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Side by Side Diff: Source/core/html/HTMLSummaryElement.cpp

Issue 59463007: Have Element::ensureUserAgentShadowRoot() return a reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add extra assertion Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLSummaryElement.h ('k') | Source/core/html/HTMLTextAreaElement.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies) 2 * Copyright (C) 2011 Nokia Corporation and/or its subsidiary(-ies)
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 : HTMLElement(tagName, document) 46 : HTMLElement(tagName, document)
47 { 47 {
48 ASSERT(hasTagName(summaryTag)); 48 ASSERT(hasTagName(summaryTag));
49 } 49 }
50 50
51 RenderObject* HTMLSummaryElement::createRenderer(RenderStyle*) 51 RenderObject* HTMLSummaryElement::createRenderer(RenderStyle*)
52 { 52 {
53 return new RenderBlockFlow(this); 53 return new RenderBlockFlow(this);
54 } 54 }
55 55
56 void HTMLSummaryElement::didAddUserAgentShadowRoot(ShadowRoot* root) 56 void HTMLSummaryElement::didAddUserAgentShadowRoot(ShadowRoot& root)
57 { 57 {
58 root->appendChild(DetailsMarkerControl::create(document())); 58 root.appendChild(DetailsMarkerControl::create(document()));
59 root->appendChild(HTMLContentElement::create(document())); 59 root.appendChild(HTMLContentElement::create(document()));
60 } 60 }
61 61
62 HTMLDetailsElement* HTMLSummaryElement::detailsElement() const 62 HTMLDetailsElement* HTMLSummaryElement::detailsElement() const
63 { 63 {
64 Node* parent = NodeRenderingTraversal::parent(this); 64 Node* parent = NodeRenderingTraversal::parent(this);
65 if (parent && isHTMLDetailsElement(parent)) 65 if (parent && isHTMLDetailsElement(parent))
66 return toHTMLDetailsElement(parent); 66 return toHTMLDetailsElement(parent);
67 return 0; 67 return 0;
68 } 68 }
69 69
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
133 133
134 bool HTMLSummaryElement::willRespondToMouseClickEvents() 134 bool HTMLSummaryElement::willRespondToMouseClickEvents()
135 { 135 {
136 if (isMainSummary() && renderer()) 136 if (isMainSummary() && renderer())
137 return true; 137 return true;
138 138
139 return HTMLElement::willRespondToMouseClickEvents(); 139 return HTMLElement::willRespondToMouseClickEvents();
140 } 140 }
141 141
142 } 142 }
OLDNEW
« no previous file with comments | « Source/core/html/HTMLSummaryElement.h ('k') | Source/core/html/HTMLTextAreaElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698