content/public/test/content_test_suite_base.cc - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/content_test_suite_base.cc

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/public/test/DEPS ('k') | content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/content_test_suite_base.cc

diff --git a/content/public/test/content_test_suite_base.cc b/content/public/test/content_test_suite_base.cc

index 70666e5cf9cac15004df3b8785c80cc0d3c2b734..9b11678ebcc997c6c6ef3a0f4eac66b5db4913b2 100644

--- a/content/public/test/content_test_suite_base.cc

+++ b/content/public/test/content_test_suite_base.cc

@@ -37,6 +37,10 @@

#include "ui/shell_dialogs/android/shell_dialogs_jni_registrar.h"

#endif

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+#include "gin/public/isolate_holder.h"

+#endif

namespace content {

class ContentTestSuiteBaseListener : public testing::EmptyTestEventListener {

@@ -62,6 +66,10 @@ void ContentTestSuiteBase::Initialize() {

// by tests.

base::StatisticsRecorder::Initialize();

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+ gin::IsolateHolder::LoadV8Snapshot();

+#endif

#if defined(OS_ANDROID)

// Register JNI bindings for android.

JNIEnv* env = base::android::AttachCurrentThread();