chrome/js_unittest_rules.gypi - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/js_unittest_rules.gypi

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: sync Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/js_unittest_rules.gypi

diff --git a/chrome/js_unittest_rules.gypi b/chrome/js_unittest_rules.gypi

index 27901f1c104dcef7e7a555cea8da22ea637089ae..b3dff9cbce99f3a03f65ad94c58fbe33100a9250 100644

--- a/chrome/js_unittest_rules.gypi

+++ b/chrome/js_unittest_rules.gypi

@@ -54,6 +54,15 @@

'rule_name': 'js2unit',

'extension': 'gtestjs',

'msvs_external_rule': 1,

+ 'variables': {

+ 'conditions': [

+ ['v8_use_external_startup_data==1', {

+ 'external_v8': 'y',

+ }, {

+ 'external_v8': 'n',

+ }],

+ ],

+ },

'inputs': [

'<(gypv8sh)',

'<(PRODUCT_DIR)/d8<(EXECUTABLE_SUFFIX)',

@@ -69,6 +78,7 @@

'action': [

'python',

'<@(_inputs)',

+ '--external', '<(external_v8)',

'unit',

'<(RULE_INPUT_PATH)',

'chrome/<(RULE_INPUT_DIRNAME)/<(RULE_INPUT_ROOT).<(_extension)',

« no previous file with comments | « chrome/interactive_ui_tests.isolate ('k') | chrome/sync_integration_tests.isolate » ('j') | no next file with comments »