tools/gypv8sh.py - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gypv8sh.py

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Disable external snapshot for webview Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gypv8sh.py

diff --git a/tools/gypv8sh.py b/tools/gypv8sh.py

index 3f81a8bc94c280e2eae9c835d0a25cdd17002ba1..2a05ae0616272de1898532f53ae0a3a0843bd262 100755

--- a/tools/gypv8sh.py

+++ b/tools/gypv8sh.py

@@ -36,6 +36,12 @@ def main ():

icudatafile = os.path.join(os.path.dirname(v8_shell), 'icudtl.dat')

if os.path.exists(icudatafile):

cmd.extend(['--icu-data-file=%s' % icudatafile])

+ v8nativesfile = os.path.join(os.path.dirname(v8_shell), 'natives_blob.bin')

+ if os.path.exists(v8nativesfile):

+ cmd.extend(['--natives_blob=%s' % v8nativesfile])

+ v8snapshotfile = os.path.join(os.path.dirname(v8_shell), 'snapshot_blob.bin')

+ if os.path.exists(v8snapshotfile):

+ cmd.extend(['--snapshot_blob=%s' % v8snapshotfile])

arguments = [js2webui, inputfile, inputrelfile, opts.deps_js,

cxxoutfile, test_type]

cmd.extend(['-e', "arguments=" + json.dumps(arguments), mock_js,

« gin/isolate_holder.cc ('K') | « third_party/android_webview_glue/android_webview_glue.gypi ('k') | no next file » | no next file with comments »