build/get_landmines.py - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/get_landmines.py

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove remaining non-android bit and fix dependency to be android only Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/get_landmines.py

diff --git a/build/get_landmines.py b/build/get_landmines.py

index f15d8dbd28b408c3c128639fba3e970bff65a771..f874ef7d04026b8d54b56a46719c7cd8e9653760 100755

--- a/build/get_landmines.py

+++ b/build/get_landmines.py

@@ -56,6 +56,8 @@ def print_landmines():

print '[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...'

print 'blink_resources.grd changed: crbug.com/400860'

print 'ninja dependency cycle: crbug.com/408192'

+ if platform() != 'android':

+ print 'Need clobber for V8 external snapshot changes: crbug.com/421063'

if platform() == 'android':

print 'Clobber: To delete stale generated .java files.'

print 'Delete stale generated .java files again. crbug.com/349592'

« build/common.gypi ('K') | « build/common.gypi ('k') | build/isolate.gypi » ('j') | no next file with comments »