Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4598)

Unified Diff: build/get_landmines.py

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sync master Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/get_landmines.py
diff --git a/build/get_landmines.py b/build/get_landmines.py
index f15d8dbd28b408c3c128639fba3e970bff65a771..764bb87c4bc74e93930395ff9d61335a758f63f6 100755
--- a/build/get_landmines.py
+++ b/build/get_landmines.py
@@ -56,6 +56,7 @@ def print_landmines():
print '[chromium-dev] PSA: clobber build needed for IDR_INSPECTOR_* compil...'
print 'blink_resources.grd changed: crbug.com/400860'
print 'ninja dependency cycle: crbug.com/408192'
+ print 'Need clobber build for V8 external snapshot changes: crbug.com/421063'
jochen (gone - plz use gerrit) 2014/10/15 15:40:14 only required for android, no? Just move it down b
baixo1 2014/10/16 10:10:30 It's the opposite, actually. We do not want a snap
if platform() == 'android':
print 'Clobber: To delete stale generated .java files.'
print 'Delete stale generated .java files again. crbug.com/349592'

Powered by Google App Engine
This is Rietveld 408576698