chrome/chrome_android_paks.gypi - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_android_paks.gypi

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ross' comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_android_paks.gypi

diff --git a/chrome/chrome_android_paks.gypi b/chrome/chrome_android_paks.gypi

index 622ff61ffaa742e6edca3a972026a9b5b8087b1a..574d5ccc545bf34fb0a83125a56f83f0808b4216 100644

--- a/chrome/chrome_android_paks.gypi

+++ b/chrome/chrome_android_paks.gypi

@@ -104,10 +104,20 @@

['icu_use_data_file_flag==1', {

'chrome_android_pak_input_resources': [

'<(PRODUCT_DIR)/icudtl.dat',

- ],

+ ],

'chrome_android_pak_output_resources': [

'<(chrome_android_pak_output_folder)/icudtl.dat',

- ],

+ ],

+ }],

+ ['v8_use_external_startup_data==1', {

+ 'chrome_android_pak_input_resources': [

+ '<(PRODUCT_DIR)/natives_blob.bin',

+ '<(PRODUCT_DIR)/snapshot_blob.bin',

+ ],

+ 'chrome_android_pak_output_resources': [

+ '<(chrome_android_pak_output_folder)/natives_blob.bin',

+ '<(chrome_android_pak_output_folder)/snapshot_blob.bin',

+ ],

}],

« build/common.gypi ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/chrome_dll_bundle.gypi » ('j') | chrome/chrome_dll_bundle.gypi » ('J')