net/net.gyp - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/net.gyp

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ross' comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: net/net.gyp

diff --git a/net/net.gyp b/net/net.gyp

index e570e8ebb73587f62184562558e32ea0416f88ee..befd8d379db1a16c4308aa2152142fa8b079fdda 100644

--- a/net/net.gyp

+++ b/net/net.gyp

@@ -1651,7 +1651,28 @@

'variables': {

'test_suite_name': 'net_unittests',

+ 'conditions': [

+ ['v8_use_external_startup_data==1', {

+ 'additional_input_paths': [

+ '<(PRODUCT_DIR)/natives_blob.bin',

+ '<(PRODUCT_DIR)/snapshot_blob.bin',

+ ],

+ }],

+ ],

+ 'copies': [

+ {

+ 'destination': '<(PRODUCT_DIR)/net_unittests_apk/assets',

+ 'conditions': [

+ ['v8_use_external_startup_data==1', {

+ 'files': [

+ '<(PRODUCT_DIR)/natives_blob.bin',

+ '<(PRODUCT_DIR)/snapshot_blob.bin',

+ ],

+ }],

+ ],

+ },

+ ],

'includes': [ '../build/apk_test.gypi' ],

« mojo/apps/js/test/js_to_cpp_unittest.cc ('K') | « mojo/apps/js/test/js_to_cpp_unittest.cc ('k') | net/proxy/proxy_resolver_v8.cc » ('j') | net/proxy/proxy_resolver_v8.cc » ('J')