mojo/apps/js/standalone_main.cc - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/apps/js/standalone_main.cc

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ross' comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« mojo/apps/js/application_delegate_impl.cc ('K') | « mojo/apps/js/content_handler_main.cc ('k') | mojo/apps/js/test/js_to_cpp_unittest.cc » ('j') | mojo/apps/js/test/js_to_cpp_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/apps/js/standalone_main.cc

diff --git a/mojo/apps/js/standalone_main.cc b/mojo/apps/js/standalone_main.cc

index efdfcb872f448cab69c87d90b8aa8ff71a57f980..c5d0c17359f2c107ec9a35d397508e8560b4d7a5 100644

--- a/mojo/apps/js/standalone_main.cc

+++ b/mojo/apps/js/standalone_main.cc

@@ -11,6 +11,10 @@

#include "mojo/public/cpp/application/application_delegate.h"

#include "mojo/public/cpp/application/application_impl.h"

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+#include "gin/public/isolate_holder.h"

+#endif

namespace mojo {

namespace apps {

@@ -49,6 +53,9 @@ class StandaloneApplicationDelegateImpl : public ApplicationDelegateImpl {

MojoResult MojoMain(MojoHandle shell_handle) {

base::i18n::InitializeICU();

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+ gin::IsolateHolder::LoadV8Snapshot();

+#endif

mojo::ApplicationRunnerChromium runner(

new mojo::apps::StandaloneApplicationDelegateImpl());

return runner.Run(shell_handle);