content/public/test/render_view_test.cc - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/test/render_view_test.cc

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address Ross' comments Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/content_tests.gypi ('K') | « content/public/common/content_descriptors.h ('k') | content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java » ('j') | gin/isolate_holder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/test/render_view_test.cc

diff --git a/content/public/test/render_view_test.cc b/content/public/test/render_view_test.cc

index f8f00883209885e0b9cd735ee3076c5d58efb7b0..ef26912f54066defe065dc7d777de9f0708a81a5 100644

--- a/content/public/test/render_view_test.cc

+++ b/content/public/test/render_view_test.cc

@@ -38,6 +38,10 @@

#include "base/mac/scoped_nsautorelease_pool.h"

#endif

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+#include "gin/public/isolate_holder.h"

+#endif

using blink::WebInputEvent;

using blink::WebLocalFrame;

using blink::WebMouseEvent;

@@ -165,6 +169,11 @@ void RenderViewTest::SetUp() {

// hacky, but this is the world we live in...

std::string flags("--expose-gc");

v8::V8::SetFlagsFromString(flags.c_str(), static_cast<int>(flags.size()));

+#ifdef V8_USE_EXTERNAL_STARTUP_DATA

+ gin::IsolateHolder::LoadV8Snapshot();

+#endif

blink::initialize(blink_platform_impl_.Get());

// Ensure that we register any necessary schemes when initializing WebKit,