Infrastructure for reading V8's initial snapshot from external files

chrome/chrome_tests_unit.gypi

Index: chrome/chrome_tests_unit.gypi
diff --git a/chrome/chrome_tests_unit.gypi b/chrome/chrome_tests_unit.gypi
index 02f892707fb97b268b85a1f95b976c9084e7d225..50e7f85ab7ba864d4df66c4689786cac09a52823 100644
--- a/chrome/chrome_tests_unit.gypi
+++ b/chrome/chrome_tests_unit.gypi
@@ -2842,7 +2842,28 @@
           'variables': {
             'test_suite_name': 'unit_tests',
             'android_manifest_path': 'test/android/unit_tests_apk/AndroidManifest.xml',
+            'conditions': [
+              ['v8_use_external_startup_data==1', {
+                'additional_input_paths': [
+                  '<(PRODUCT_DIR)/natives_blob.bin',
+                  '<(PRODUCT_DIR)/snapshot_blob.bin',
+                ],
+              }],
+            ],
           },
+          'copies': [
+            {
+              'destination': '<(PRODUCT_DIR)/unit_tests_apk/assets',
+	            'conditions': [
+                ['v8_use_external_startup_data==1', {
+                  'files': [
+                    '<(PRODUCT_DIR)/natives_blob.bin',
+                    '<(PRODUCT_DIR)/snapshot_blob.bin',
+                  ],
+                }],
+              ],
+            },
+          ],

[rmcilroy, 2014/10/06 15:41:02]

I don't think the changes in this file are necessary because unit_tests_apk
depends on chrome_java, and this already does the packaging in
chrome_android_paks.gypi (pulled in through chrome chrome_android.gypi which is
included in the chrome_java target).  Does it still work without the changes in
this target?  (I think it should because ICU data is not explicitly mentioned on
this target).

[baixo, 2014/10/07 14:53:27]

Unfortunately it doesn't work without these changes. The packaging you mentioned
does not ensure that the snapshot files end up in the unit_tests_apk. (I think
ICU is not called in these tests).

           'includes': [ '../build/apk_test.gypi' ],
         },
       ],