build/common.gypi - Issue 594603003: Infrastructure for reading V8's initial snapshot from external files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Properly override v8_use_external_snapshot in v8 Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index d00b6a70826b131ca5f16cea034b2ede8823d8df..4c43cdd909d1d1c05798885d2dbd4da161f28ec2 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2366,6 +2366,7 @@

# Whether to allow building of the GPU-related isolates.

'archive_gpu_tests%': 0,

+ 'v8_use_external_startup_data': 1,

'target_defaults': {

'variables': {

@@ -2967,6 +2968,9 @@

['enable_load_completion_hacks==1', {

'defines': ['ENABLE_LOAD_COMPLETION_HACKS=1'],

}],

+ ['v8_use_external_startup_data==1', {

+ 'defines': ['V8_USE_EXTERNAL_STARTUP_DATA'],

+ }],

], # conditions for 'target_defaults'

'target_conditions': [

['<(use_openssl)==1', {

« no previous file with comments | « no previous file | chrome/browser/chrome_content_browser_client.cc » ('j') | chrome/browser/chrome_content_browser_client.cc » ('J')