Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Side by Side Diff: gin/public/isolate_holder.h

Issue 594603003: Infrastructure for reading V8's initial snapshot from external files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Ross' comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_ 5 #ifndef GIN_PUBLIC_ISOLATE_HOLDER_H_
6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_ 6 #define GIN_PUBLIC_ISOLATE_HOLDER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "gin/gin_export.h" 10 #include "gin/gin_export.h"
11 #include "v8/include/v8.h" 11 #include "v8/include/v8.h"
12 12
13 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
14 #include "base/files/memory_mapped_file.h"
rmcilroy 2014/10/07 16:16:11 Do you need this include in the header?
baixo 2014/10/08 11:28:55 No. But I need base/files/file_path.h :).
15 #endif
16
13 namespace gin { 17 namespace gin {
14 18
15 class PerIsolateData; 19 class PerIsolateData;
16 class RunMicrotasksObserver; 20 class RunMicrotasksObserver;
17 21
18 // To embed Gin, first initialize gin using IsolateHolder::Initialize and then 22 // To embed Gin, first initialize gin using IsolateHolder::Initialize and then
19 // create an instance of IsolateHolder to hold the v8::Isolate in which you 23 // create an instance of IsolateHolder to hold the v8::Isolate in which you
20 // will execute JavaScript. You might wish to subclass IsolateHolder if you 24 // will execute JavaScript. You might wish to subclass IsolateHolder if you
21 // want to tie more state to the lifetime of the isolate. 25 // want to tie more state to the lifetime of the isolate.
22 class GIN_EXPORT IsolateHolder { 26 class GIN_EXPORT IsolateHolder {
23 public: 27 public:
24 // Controls whether or not V8 should only accept strict mode scripts. 28 // Controls whether or not V8 should only accept strict mode scripts.
25 enum ScriptMode { 29 enum ScriptMode {
26 kNonStrictMode, 30 kNonStrictMode,
27 kStrictMode 31 kStrictMode
28 }; 32 };
29 33
30 IsolateHolder(); 34 IsolateHolder();
31 ~IsolateHolder(); 35 ~IsolateHolder();
32 36
33 // Should be invoked once before creating IsolateHolder instances to 37 // Should be invoked once before creating IsolateHolder instances to
34 // initialize V8 and Gin. 38 // initialize V8 and Gin.
rmcilroy 2014/10/07 16:16:11 Please add a comment here that if V8_USE_EXTERNAL_
baixo 2014/10/08 11:28:55 Done.
35 static void Initialize(ScriptMode mode, 39 static void Initialize(ScriptMode mode,
36 v8::ArrayBuffer::Allocator* allocator); 40 v8::ArrayBuffer::Allocator* allocator);
37 41
38 v8::Isolate* isolate() { return isolate_; } 42 v8::Isolate* isolate() { return isolate_; }
39 43
40 // The implementations of Object.observe() and Promise enqueue v8 Microtasks 44 // The implementations of Object.observe() and Promise enqueue v8 Microtasks
41 // that should be executed just before control is returned to the message 45 // that should be executed just before control is returned to the message
42 // loop. This method adds a MessageLoop TaskObserver which runs any pending 46 // loop. This method adds a MessageLoop TaskObserver which runs any pending
43 // Microtasks each time a Task is completed. This method should be called 47 // Microtasks each time a Task is completed. This method should be called
44 // once, when a MessageLoop is created and it should be called on the 48 // once, when a MessageLoop is created and it should be called on the
45 // MessageLoop's thread. 49 // MessageLoop's thread.
46 void AddRunMicrotasksObserver(); 50 void AddRunMicrotasksObserver();
47 51
48 // This method should also only be called once, and on the MessageLoop's 52 // This method should also only be called once, and on the MessageLoop's
49 // thread. 53 // thread.
50 void RemoveRunMicrotasksObserver(); 54 void RemoveRunMicrotasksObserver();
51 55
56 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
57 #ifdef OS_ANDROID
58 static bool LoadV8SnapshotFD(int natives_fd, int snapshot_fd);
59 #endif
60 static bool LoadV8Snapshot();
61 #endif // V8_USE_EXTERNAL_STARTUP_DATA
62
52 private: 63 private:
53 v8::Isolate* isolate_; 64 v8::Isolate* isolate_;
54 scoped_ptr<PerIsolateData> isolate_data_; 65 scoped_ptr<PerIsolateData> isolate_data_;
55 scoped_ptr<RunMicrotasksObserver> task_observer_; 66 scoped_ptr<RunMicrotasksObserver> task_observer_;
56 67
68 #ifdef V8_USE_EXTERNAL_STARTUP_DATA
69
70 static bool MapV8Files(
71 base::FilePath* natives_path, base::FilePath* snapshot_path,
72 int natives = -1, int snapshot = -1);
73
74 #endif // V8_USE_EXTERNAL_STARTUP_DATA
75
57 DISALLOW_COPY_AND_ASSIGN(IsolateHolder); 76 DISALLOW_COPY_AND_ASSIGN(IsolateHolder);
58 }; 77 };
59 78
60 } // namespace gin 79 } // namespace gin
61 80
62 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_ 81 #endif // GIN_PUBLIC_ISOLATE_HOLDER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698