Infrastructure for reading V8's initial snapshot from external files

mojo/apps/js/js_app.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/apps/js/js_app.h"
 
 #include "base/bind.h"
 #include "gin/array_buffer.h"
 #include "gin/converter.h"
 #include "mojo/apps/js/application_delegate_impl.h"
 #include "mojo/apps/js/mojo_module.h"
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+#include "gin/public/isolate_holder.h"
+#endif
+
 namespace mojo {
 namespace apps {
 
 JSApp::JSApp(ApplicationDelegateImpl* app_delegate_impl)
     : app_delegate_impl_(app_delegate_impl),
       thread_("Mojo JS"),
       app_delegate_impl_task_runner_(
           base::MessageLoop::current()->task_runner()) {
   CHECK(on_app_delegate_impl_thread());
   runner_delegate_.AddBuiltinModule(Mojo::kModuleName,
@@ skipping 42 matching lines @@
 }
 
 void JSApp::Run() {
   CHECK(!js_app_task_runner_.get() && !on_app_delegate_impl_thread());
   js_app_task_runner_ = base::MessageLoop::current()->task_runner();
 
   std::string source;
   std::string file_name;
   Load(&source, &file_name);  // TODO(hansmuller): handle Load() failure.
 
+#ifdef V8_USE_EXTERNAL_STARTUP_DATA
+  gin::IsolateHolder::LoadV8Snapshot();

[rmcilroy, 2014/10/06 15:41:03]

Is this required given the change in content_handler_main.cc /
standalone_main.cc?  I think those should be enough since MojoMain should always
be called before this Run() method.

[baixo, 2014/10/07 14:53:28]

Done.

+#endif
+
   isolate_holder_.reset(new gin::IsolateHolder());
   isolate_holder_->AddRunMicrotasksObserver();
 
   shell_runner_.reset(
       new gin::ShellRunner(&runner_delegate_, isolate_holder_->isolate()));
 
   gin::Runner::Scope scope(shell_runner_.get());
   shell_runner_->Run(source.c_str(), file_name.c_str());
 }
 
@@ skipping 18 matching lines @@
 }
 
 bool JSApp::on_js_app_thread() const {
   return js_app_task_runner_.get() &&
          js_app_task_runner_.get() ==
              base::MessageLoop::current()->task_runner().get();
 }
 
 }  // namespace apps
 }  // namespace mojo