Compile ui/keyboard/ JS, part 1: remove all warnings

Compile ui/keyboard/ JS, part 1: remove all warnings

R=bshe@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . ui/keyboard/resources/compiled_resources.gyp && ninja -C out/Default | grep WARNING

Committed: https://crrev.com/46cbfd62f398472650985747d459bb7869578918
Cr-Commit-Position: refs/heads/master@{#296296}

[Vitaly Pavlenko, 2014-09-22 17:19:20]

Hi bshe@,

I'm compiling JS source in Chrome that is exposed to end users. As a part of it,
I started compiling ui/keyboard/. Is it a good idea to do so? Could you review
my changes?

Design doc:
https://docs.google.com/a/google.com/document/d/1Ee9ggmp6U-lM-w9WmxN5cSLkK9B5...

[bshe, 2014-09-22 19:00:29]

bshe@chromium.org changed reviewers:
+ kevers@chromium.org

[bshe, 2014-09-22 19:00:29]

+kevers

The js code is going to be removed soon and will be replaced by code in 3rd
party directory which is essentially closure compiled js library. So it is
probably not necessary to do so here. WDYT kevers?

[kevers, 2014-09-22 20:03:33]

On 2014/09/22 19:00:29, bshe wrote:
> +kevers
> 
> The js code is going to be removed soon and will be replaced by code in 3rd
> party directory which is essentially closure compiled js library. So it is
> probably not necessary to do so here. WDYT kevers?

As Biao mentioned, this code is slated for removal shortly; however, I'm happy
to see the cleanup in the interim.  The code transition will not be finalized
until M40.  LGTM.

[bshe, 2014-09-22 21:16:43]

On 2014/09/22 20:03:33, kevers wrote:
> On 2014/09/22 19:00:29, bshe wrote:
> > +kevers
> > 
> > The js code is going to be removed soon and will be replaced by code in 3rd
> > party directory which is essentially closure compiled js library. So it is
> > probably not necessary to do so here. WDYT kevers?
> 
> As Biao mentioned, this code is slated for removal shortly; however, I'm happy
> to see the cleanup in the interim.  The code transition will not be finalized
> until M40.  LGTM.

lgtm

[Vitaly Pavlenko, 2014-09-23 21:50:48]

The CQ bit was checked by vitalyp@chromium.org

[commit-bot: I haz the power, 2014-09-23 21:52:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594603002/1

[commit-bot: I haz the power, 2014-09-23 23:18:26]

Committed patchset #1 (id:1) as 1f6e35841b75e8da992cab1ede54f9e74bf064d6

[commit-bot: I haz the power, 2014-09-23 23:19:06]

Patchset 1 (id:??) landed as
https://crrev.com/46cbfd62f398472650985747d459bb7869578918
Cr-Commit-Position: refs/heads/master@{#296296}