Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 594533002: Replace HTMLMediaElement::isActive() with Node::inActiveDocument() (Closed)

Created:
6 years, 3 months ago by philipj_slow
Modified:
6 years, 1 month ago
Reviewers:
fs
CC:
blink-reviews, blink-reviews-rendering, blink-reviews-html_chromium.org, zoltan1, eae+blinkwatch, philipj_slow, gasubic, fs, eric.carlson_apple.com, leviw+renderwatch, feature-media-reviews_chromium.org, dglazkov+blink, nessy, jchaffraix+rendering, pdr+renderingwatchlist_chromium.org, vcarbune.chromium, rune+blink
Project:
blink
Visibility:
Public.

Description

Replace HTMLMediaElement::isActive() with Node::inActiveDocument() The m_active flag was previously named m_inActiveDocument: https://codereview.chromium.org/26270004 Because m_active is updated in HTMLMediaElement::insertedInto(), removedFrom() and stop(), HTMLMediaElement::isActive() it is very similar to Node::inActiveDocument(), with the difference that in the early stages of a Document's life, inActiveDocument() is false while isActive() is true. In RenderVideo, the difference is irrelevant, because nothing is being rendered at that point in the lifecycle. The usage in HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests() was added to fix failing tests in https://bugs.webkit.org/show_bug.cgi?id=105606: media/track/tracklist-is-reachable.html media/track/text-track-cue-is-reachable.html media/track/text-track-is-reachable.html media/track/track-webvtt-tc005-header-comment.html media/track/track-webvtt-tc004-magic-header.html media/track/track-webvtt-tc016-align-positioning.html All of these are still passing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185854

Patch Set 1 #

Patch Set 2 : crash less #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -11 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 1 2 5 chunks +2 lines, -7 lines 0 comments Download
M Source/core/rendering/RenderVideo.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
philipj_slow
PTAL
6 years, 1 month ago (2014-11-21 11:51:40 UTC) #2
fs
lgtm
6 years, 1 month ago (2014-11-21 12:17:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594533002/20001
6 years, 1 month ago (2014-11-21 22:44:44 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/20468)
6 years, 1 month ago (2014-11-21 22:51:07 UTC) #7
philipj_slow
rebase
6 years, 1 month ago (2014-11-23 19:58:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594533002/40001
6 years, 1 month ago (2014-11-23 19:59:20 UTC) #10
commit-bot: I haz the power
6 years, 1 month ago (2014-11-23 21:09:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=185854

Powered by Google App Engine
This is Rietveld 408576698