DescriptionReplace HTMLMediaElement::isActive() with Node::inActiveDocument()
The m_active flag was previously named m_inActiveDocument:
https://codereview.chromium.org/26270004
Because m_active is updated in HTMLMediaElement::insertedInto(),
removedFrom() and stop(), HTMLMediaElement::isActive() it is very
similar to Node::inActiveDocument(), with the difference that in the
early stages of a Document's life, inActiveDocument() is false while
isActive() is true.
In RenderVideo, the difference is irrelevant, because nothing is being
rendered at that point in the lifecycle.
The usage in HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests()
was added to fix failing tests in
https://bugs.webkit.org/show_bug.cgi?id=105606:
media/track/tracklist-is-reachable.html
media/track/text-track-cue-is-reachable.html
media/track/text-track-is-reachable.html
media/track/track-webvtt-tc005-header-comment.html
media/track/track-webvtt-tc004-magic-header.html
media/track/track-webvtt-tc016-align-positioning.html
All of these are still passing.
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185854
Patch Set 1 #Patch Set 2 : crash less #Patch Set 3 : rebase #
Messages
Total messages: 11 (4 generated)
|