Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3739)

Unified Diff: editor/build/build.py

Issue 59453012: Implemented archiving of apidocs for all channels (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | editor/build/promote.py » ('j') | tools/bots/bot_utils.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: editor/build/build.py
diff --git a/editor/build/build.py b/editor/build/build.py
index 8f465e8ba97a081e7791bae2de6bac238756f794..ed770243bf07404c566dbeac8717c32bfb58a0ae 100755
--- a/editor/build/build.py
+++ b/editor/build/build.py
@@ -24,9 +24,6 @@ BUILD_OS = None
DART_PATH = None
TOOLS_PATH = None
-GSU_API_DOCS_PATH = None
-GSU_API_DOCS_BUCKET = 'gs://dartlang-api-docs'
-
CHANNEL = None
PLUGINS_BUILD = None
REVISION = None
@@ -1188,32 +1185,26 @@ def CreateZipWindows(directory, targetFile):
os.path.dirname(directory))
-def UploadDirectory(filesToUpload, gs_dir):
- Gsutil(['-m', 'cp', '-a', 'public-read', '-r'] + filesToUpload + [gs_dir])
-
-
def UploadApiDocs(dirName):
- # create file in dartlang-api-docs/REVISION/index.html
- # this lets us do the recursive copy in the next step
-
- localIndexFile = join(dirName, 'index.html')
- destIndexFile = GSU_API_DOCS_PATH + '/index.html'
+ apidocs_namer = bot_utils.GCSNamerApiDocs(CHANNEL)
+ apidocs_destination_gcsdir = apidocs_namer.docs_dirpath(REVISION)
+ apidocs_destination_latestfile = apidocs_namer.docs_latestpath(REVISION)
- Gsutil(['cp', '-a', 'public-read', localIndexFile, destIndexFile])
+ # Delete the old revision specific apidocs directory if present.
+ Gsutil(['-m', 'rm', '-R', '-f', apidocs_destination_gcsdir])
- # copy -R api_docs into dartlang-api-docs/REVISION
- filesToUpload = glob.glob(join(dirName, '*'))
- Gsutil(['-m', 'cp', '-q', '-a', 'public-read', '-r'] +
- filesToUpload + [GSU_API_DOCS_PATH])
+ # Upload everything inside the built apidocs directory.
+ Gsutil(['-m', 'cp', '-R', '-a', 'public-read', dirName,
+ apidocs_destination_gcsdir])
- destLatestRevFile = GSU_API_DOCS_BUCKET + '/latest.txt'
- localLatestRevFilename = join(dirName, 'latest.txt')
- with open(localLatestRevFilename, 'w+') as f:
- f.write(REVISION)
+ # Update latest.txt to contain the newest revision.
+ with utils.TempDir('latest_file') as temp_dir:
+ latest_file = join(temp_dir, 'latest.txt')
+ with open(latest_file, 'w') as f:
+ f.write('%s' % REVISION)
- # overwrite dartlang-api-docs/latest.txt to contain REVISION
- Gsutil(['cp', '-a', 'public-read', localLatestRevFilename,
- destLatestRevFile])
+ Gsutil(['cp', '-a', 'public-read', latest_file,
+ apidocs_destination_latestfile])
def Gsutil(cmd):
« no previous file with comments | « no previous file | editor/build/promote.py » ('j') | tools/bots/bot_utils.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698