Issue 594513002: Do not serialize non-lazy compiled function literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 594513002: Do not serialize non-lazy compiled function literals. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

More Reviews

Description

Do not serialize non-lazy compiled function literals. ... and some small refactorings. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24266

Patch Set 1 #

Total comments: 1

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -61 lines)			Patch
M	src/compiler.h	View	2 chunks	+6 lines, -1 line	0 comments	Download
M	src/compiler.cc	View	2 chunks	+9 lines, -0 lines	0 comments	Download
M	src/serialize.h	View	2 chunks	+16 lines, -14 lines	0 comments	Download
M	src/serialize.cc	View	7 chunks	+33 lines, -46 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

mvstanton

lgtm https://codereview.chromium.org/594513002/diff/1/src/serialize.cc File src/serialize.cc (right): https://codereview.chromium.org/594513002/diff/1/src/serialize.cc#newcode1904 src/serialize.cc:1904: // Past this point we should not see ...

6 years, 2 months ago (2014-09-26 12:28:49 UTC) #2

Yang

6 years, 2 months ago (2014-09-29 07:53:33 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 24266 (presubmit successful).

Expand Messages | Collapse Messages