Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 594503004: Move ownership of the tool-bar's menu buttons into remoting.Toolbar. (Closed)

Created:
6 years, 3 months ago by Jamie
Modified:
6 years, 3 months ago
Reviewers:
kelvinp
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ownership of the tool-bar's menu buttons into remoting.Toolbar. This CL also reinstates the previous behaviour of MenuButton whereby a second click on the button hides the menu, which is made possible by a saner ownership model. BUG=415410 Committed: https://crrev.com/f12832d351fc43392cdcfb4ec2418a9b53431fdf Cr-Commit-Position: refs/heads/master@{#296284}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove MenuButton changes (will follow up with a better fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -77 lines) Patch
M remoting/webapp/client_screen.js View 1 chunk +4 lines, -2 lines 0 comments Download
M remoting/webapp/client_session.js View 7 chunks +2 lines, -47 lines 0 comments Download
M remoting/webapp/options_menu.js View 2 chunks +7 lines, -0 lines 0 comments Download
M remoting/webapp/remoting.js View 3 chunks +4 lines, -2 lines 0 comments Download
M remoting/webapp/toolbar.js View 4 chunks +38 lines, -10 lines 0 comments Download
M remoting/webapp/window_frame.js View 4 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jamie
ptal https://codereview.chromium.org/594503004/diff/1/remoting/webapp/window_frame.js File remoting/webapp/window_frame.js (right): https://codereview.chromium.org/594503004/diff/1/remoting/webapp/window_frame.js#newcode61 remoting/webapp/window_frame.js:61: base.debug.assert(this.optionsMenuList_ != null); Unrelated typo fix. I can ...
6 years, 3 months ago (2014-09-22 18:20:04 UTC) #2
kelvinp
lgtm
6 years, 3 months ago (2014-09-23 21:06:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594503004/20001
6 years, 3 months ago (2014-09-23 21:16:36 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 17a16f9206a0e39b8eb79f873faa74b33cce899e
6 years, 3 months ago (2014-09-23 22:29:41 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-23 22:30:40 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f12832d351fc43392cdcfb4ec2418a9b53431fdf
Cr-Commit-Position: refs/heads/master@{#296284}

Powered by Google App Engine
This is Rietveld 408576698