Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 594503003: [NaCl SDK] Fix SDK to have pnacl as default toolchain. (Closed)

Created:
6 years, 3 months ago by binji
Modified:
6 years, 3 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Fix SDK to have pnacl as default toolchain. BUG=none R=sbc@chromium.org Committed: https://crrev.com/04b8324d8c252c8110037ec5fb4344ac8035addf Cr-Commit-Position: refs/heads/master@{#296028}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M native_client_sdk/src/build_tools/build_sdk.py View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 3 months ago (2014-09-22 17:37:02 UTC) #1
Sam Clegg
hmm. wonder how that regressed?
6 years, 3 months ago (2014-09-22 17:41:18 UTC) #2
Sam Clegg
lgtm
6 years, 3 months ago (2014-09-22 17:41:22 UTC) #3
binji
On 2014/09/22 17:41:18, Sam Clegg wrote: > hmm. wonder how that regressed? Well, we don't ...
6 years, 3 months ago (2014-09-22 17:42:46 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-22 19:56:02 UTC) #5
Patchset 1 (id:??) landed as
https://crrev.com/04b8324d8c252c8110037ec5fb4344ac8035addf
Cr-Commit-Position: refs/heads/master@{#296028}

Powered by Google App Engine
This is Rietveld 408576698