Source/web/WebRemoteFrameImpl.cpp - Issue 594483002: Oilpan: extend tracing over WebFrame trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 594483002: Oilpan: extend tracing over WebFrame trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Improve weak callback registration Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index 36df664b85912417c1c6f8ee378ed20f474a43b9..f3c7288a4e7d8fb94ea2851beff227b1c1875516 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -132,15 +132,15 @@ WebRemoteFrameImpl::~WebRemoteFrameImpl()

{

}

+#if ENABLE(OILPAN)

void WebRemoteFrameImpl::trace(Visitor* visitor)

{

-#if ENABLE(OILPAN)

visitor->trace(m_frame);

visitor->trace(m_ownersForChildren);

- WebFrame::traceChildren(visitor, this);

-#endif

+ visitor->registerWeakMembers<WebFrame, &WebFrame::clearWeakFrames>(this);

+ WebFrame::traceFrames(visitor, this);

}

+#endif

bool WebRemoteFrameImpl::isWebLocalFrame() const

{

« no previous file with comments | « Source/web/WebRemoteFrameImpl.h ('k') | public/web/WebFrame.h » ('j') | no next file with comments »