Source/core/loader/FrameLoader.cpp - Issue 594483002: Oilpan: extend tracing over WebFrame trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 594483002: Oilpan: extend tracing over WebFrame trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Add not-reached assert Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/loader/FrameLoader.cpp

diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp

index 55056c63b5c9dc03dc855c24cc1339d83a7178b2..5cdc33eaff27755fc79b38215d6d25726729743e 100644

--- a/Source/core/loader/FrameLoader.cpp

+++ b/Source/core/loader/FrameLoader.cpp

@@ -247,8 +247,9 @@ void FrameLoader::didExplicitOpen()

void FrameLoader::clear()

{

- // clear() is called during (Local)Frame finalization and when creating

- // a new Document within it (DocumentLoader::createWriterFor().)

+ // clear() is called during (Local)Frame detachment or when

+ // reusing a FrameLoader by putting a new Document within it

+ // (DocumentLoader::ensureWriter().)

if (m_stateMachine.creatingInitialEmptyDocument())

return;