Source/web/WebRemoteFrameImpl.cpp - Issue 594483002: Oilpan: extend tracing over WebFrame trees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebRemoteFrameImpl.cpp

Issue 594483002: Oilpan: extend tracing over WebFrame trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Weakly handle m_opener + trace OpenedFrameTracker frames Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebRemoteFrameImpl.cpp

diff --git a/Source/web/WebRemoteFrameImpl.cpp b/Source/web/WebRemoteFrameImpl.cpp

index ddd1552ed65134b927d39c4eb5d2d695ba96b064..eaa4bcf2ab4f4abf6a73a078805c831d8bc57cc0 100644

--- a/Source/web/WebRemoteFrameImpl.cpp

+++ b/Source/web/WebRemoteFrameImpl.cpp

@@ -131,15 +131,20 @@ WebRemoteFrameImpl::~WebRemoteFrameImpl()

{

}

+#if ENABLE(OILPAN)

void WebRemoteFrameImpl::trace(Visitor* visitor)

{

-#if ENABLE(OILPAN)

visitor->trace(m_frame);

visitor->trace(m_ownersForChildren);

+ visitor->registerWeakMembers<WebRemoteFrameImpl, &WebRemoteFrameImpl::clearWeakMembers>(this);

+ WebFrame::traceFrames(visitor, this);

- WebFrame::traceChildren(visitor, this);

-#endif

+void WebRemoteFrameImpl::clearWeakMembers(Visitor* visitor)

+ WebFrame::clearWeakFrames(visitor, this);

}

+#endif

bool WebRemoteFrameImpl::isWebLocalFrame() const

{