Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Side by Side Diff: Source/web/WebRemoteFrameImpl.h

Issue 594483002: Oilpan: extend tracing over WebFrame trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Improve weak callback registration Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebRemoteFrameImpl_h 5 #ifndef WebRemoteFrameImpl_h
6 #define WebRemoteFrameImpl_h 6 #define WebRemoteFrameImpl_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "public/web/WebRemoteFrame.h" 9 #include "public/web/WebRemoteFrame.h"
10 #include "public/web/WebRemoteFrameClient.h" 10 #include "public/web/WebRemoteFrameClient.h"
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
177 177
178 void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>); 178 void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>);
179 RemoteFrame* frame() const { return m_frame.get(); } 179 RemoteFrame* frame() const { return m_frame.get(); }
180 180
181 WebRemoteFrameClient* client() const { return m_client; } 181 WebRemoteFrameClient* client() const { return m_client; }
182 182
183 static WebRemoteFrameImpl* fromFrame(RemoteFrame&); 183 static WebRemoteFrameImpl* fromFrame(RemoteFrame&);
184 184
185 virtual void initializeFromFrame(WebLocalFrame*) const OVERRIDE; 185 virtual void initializeFromFrame(WebLocalFrame*) const OVERRIDE;
186 186
187 virtual void trace(Visitor*); 187 #if ENABLE(OILPAN)
188 void trace(Visitor*);
189 #endif
188 190
189 private: 191 private:
190 RemoteFrameClientImpl m_frameClient; 192 RemoteFrameClientImpl m_frameClient;
191 RefPtrWillBeMember<RemoteFrame> m_frame; 193 RefPtrWillBeMember<RemoteFrame> m_frame;
192 WebRemoteFrameClient* m_client; 194 WebRemoteFrameClient* m_client;
193 195
194 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> > m_ownersForChi ldren; 196 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> > m_ownersForChi ldren;
195 197
196 #if ENABLE(OILPAN) 198 #if ENABLE(OILPAN)
197 // Oilpan: to provide the guarantee of having the frame live until 199 // Oilpan: to provide the guarantee of having the frame live until
198 // close() is called, an instance keep a self-persistent. It is 200 // close() is called, an instance keep a self-persistent. It is
199 // cleared upon calling close(). This avoids having to assume that 201 // cleared upon calling close(). This avoids having to assume that
200 // an embedder's WebFrame references are all discovered via thread 202 // an embedder's WebFrame references are all discovered via thread
201 // state (stack, registers) should an Oilpan GC strike while we're 203 // state (stack, registers) should an Oilpan GC strike while we're
202 // in the process of detaching. 204 // in the process of detaching.
203 GC_PLUGIN_IGNORE("340522") 205 GC_PLUGIN_IGNORE("340522")
204 Persistent<WebRemoteFrameImpl> m_selfKeepAlive; 206 Persistent<WebRemoteFrameImpl> m_selfKeepAlive;
205 #endif 207 #endif
206 }; 208 };
207 209
208 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame()); 210 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame());
209 211
210 } // namespace blink 212 } // namespace blink
211 213
212 #endif // WebRemoteFrameImpl_h 214 #endif // WebRemoteFrameImpl_h
OLDNEW
« no previous file with comments | « Source/web/WebLocalFrameImpl.cpp ('k') | Source/web/WebRemoteFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698