Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: Source/web/WebRemoteFrameImpl.h

Issue 594483002: Oilpan: extend tracing over WebFrame trees. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add not-reached assert Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebRemoteFrameImpl_h 5 #ifndef WebRemoteFrameImpl_h
6 #define WebRemoteFrameImpl_h 6 #define WebRemoteFrameImpl_h
7 7
8 #include "platform/heap/Handle.h" 8 #include "platform/heap/Handle.h"
9 #include "public/web/WebRemoteFrame.h" 9 #include "public/web/WebRemoteFrame.h"
10 #include "public/web/WebRemoteFrameClient.h" 10 #include "public/web/WebRemoteFrameClient.h"
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
180 180
181 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name); 181 void initializeCoreFrame(FrameHost*, FrameOwner*, const AtomicString& name);
182 182
183 void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>); 183 void setCoreFrame(PassRefPtrWillBeRawPtr<RemoteFrame>);
184 RemoteFrame* frame() const { return m_frame.get(); } 184 RemoteFrame* frame() const { return m_frame.get(); }
185 185
186 WebRemoteFrameClient* client() const { return m_client; } 186 WebRemoteFrameClient* client() const { return m_client; }
187 187
188 static WebRemoteFrameImpl* fromFrame(RemoteFrame&); 188 static WebRemoteFrameImpl* fromFrame(RemoteFrame&);
189 189
190 virtual void trace(Visitor*); 190 #if ENABLE(OILPAN)
191 void trace(Visitor*);
192 void clearWeakMembers(Visitor*);
193 #endif
191 194
192 private: 195 private:
193 RemoteFrameClient m_frameClient; 196 RemoteFrameClient m_frameClient;
194 RefPtrWillBeMember<RemoteFrame> m_frame; 197 RefPtrWillBeMember<RemoteFrame> m_frame;
195 WebRemoteFrameClient* m_client; 198 WebRemoteFrameClient* m_client;
196 199
197 WebViewImpl* viewImpl() const; 200 WebViewImpl* viewImpl() const;
198 201
199 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> > m_ownersForChi ldren; 202 WillBeHeapHashMap<WebFrame*, OwnPtrWillBeMember<FrameOwner> > m_ownersForChi ldren;
200 203
201 #if ENABLE(OILPAN) 204 #if ENABLE(OILPAN)
202 // Oilpan: to provide the guarantee of having the frame live until 205 // Oilpan: to provide the guarantee of having the frame live until
203 // close() is called, an instance keep a self-persistent. It is 206 // close() is called, an instance keep a self-persistent. It is
204 // cleared upon calling close(). This avoids having to assume that 207 // cleared upon calling close(). This avoids having to assume that
205 // an embedder's WebFrame references are all discovered via thread 208 // an embedder's WebFrame references are all discovered via thread
206 // state (stack, registers) should an Oilpan GC strike while we're 209 // state (stack, registers) should an Oilpan GC strike while we're
207 // in the process of detaching. 210 // in the process of detaching.
208 GC_PLUGIN_IGNORE("340522") 211 GC_PLUGIN_IGNORE("340522")
209 Persistent<WebRemoteFrameImpl> m_selfKeepAlive; 212 Persistent<WebRemoteFrameImpl> m_selfKeepAlive;
210 #endif 213 #endif
211 }; 214 };
212 215
213 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame()); 216 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame() , frame.isWebRemoteFrame());
214 217
215 } // namespace blink 218 } // namespace blink
216 219
217 #endif // WebRemoteFrameImpl_h 220 #endif // WebRemoteFrameImpl_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698