Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1859)

Unified Diff: Source/platform/network/FormData.cpp

Issue 594473002: [Thread-safe] Take deep copy of String/KURL in FormData::deepCopy() (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Add unit tests. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/network/FormData.cpp
diff --git a/Source/platform/network/FormData.cpp b/Source/platform/network/FormData.cpp
index e38093af1f1291d1a25d64ebcf8b7a339cd408fb..4641f730cad98155eaad3a41278c82cfd26bef15 100644
--- a/Source/platform/network/FormData.cpp
+++ b/Source/platform/network/FormData.cpp
@@ -95,13 +95,13 @@ PassRefPtr<FormData> FormData::deepCopy() const
formData->m_elements.uncheckedAppend(FormDataElement(e.m_data));
break;
case FormDataElement::encodedFile:
- formData->m_elements.uncheckedAppend(FormDataElement(e.m_filename, e.m_fileStart, e.m_fileLength, e.m_expectedFileModificationTime));
+ formData->m_elements.uncheckedAppend(FormDataElement(e.m_filename.isolatedCopy(), e.m_fileStart, e.m_fileLength, e.m_expectedFileModificationTime));
break;
case FormDataElement::encodedBlob:
- formData->m_elements.uncheckedAppend(FormDataElement(e.m_blobUUID, e.m_optionalBlobDataHandle));
+ formData->m_elements.uncheckedAppend(FormDataElement(e.m_blobUUID.isolatedCopy(), e.m_optionalBlobDataHandle));
break;
case FormDataElement::encodedFileSystemURL:
- formData->m_elements.uncheckedAppend(FormDataElement(e.m_fileSystemURL, e.m_fileStart, e.m_fileLength, e.m_expectedFileModificationTime));
+ formData->m_elements.uncheckedAppend(FormDataElement(e.m_fileSystemURL.copy(), e.m_fileStart, e.m_fileLength, e.m_expectedFileModificationTime));
break;
}
}

Powered by Google App Engine
This is Rietveld 408576698