Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 594473002: [Thread-safe] Take deep copy of String/KURL in FormData::deepCopy() (Closed)

Created:
6 years, 3 months ago by hiroshige
Modified:
6 years, 2 months ago
Reviewers:
abarth-chromium
CC:
mkwst+moarreviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[Thread-safe] Take deep copy of String/KURL in FormData::deepCopy() Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183963

Patch Set 1 #

Patch Set 2 : Add unit tests. #

Total comments: 2

Patch Set 3 : remove gmock.h include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -3 lines) Patch
M Source/platform/blink_platform.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/platform/network/FormData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
A Source/platform/network/FormDataTest.cpp View 1 2 1 chunk +111 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
hiroshige
6 years, 3 months ago (2014-09-22 08:50:20 UTC) #2
abarth-chromium
This CL lacks a test.
6 years, 3 months ago (2014-09-22 14:44:31 UTC) #3
hiroshige
Added a unit tests.
6 years, 2 months ago (2014-10-16 09:16:22 UTC) #5
abarth-chromium
LGTM https://codereview.chromium.org/594473002/diff/40001/Source/platform/network/FormDataTest.cpp File Source/platform/network/FormDataTest.cpp (right): https://codereview.chromium.org/594473002/diff/40001/Source/platform/network/FormDataTest.cpp#newcode11 Source/platform/network/FormDataTest.cpp:11: #include <gmock/gmock.h> Why do we need gmock?
6 years, 2 months ago (2014-10-16 16:13:19 UTC) #6
hiroshige
Thank you for reviewing! https://codereview.chromium.org/594473002/diff/40001/Source/platform/network/FormDataTest.cpp File Source/platform/network/FormDataTest.cpp (right): https://codereview.chromium.org/594473002/diff/40001/Source/platform/network/FormDataTest.cpp#newcode11 Source/platform/network/FormDataTest.cpp:11: #include <gmock/gmock.h> Removed.
6 years, 2 months ago (2014-10-20 05:16:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594473002/60001
6 years, 2 months ago (2014-10-20 05:16:32 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-20 06:16:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as 183963

Powered by Google App Engine
This is Rietveld 408576698