Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1702)

Unified Diff: chrome/browser/resources/history/history.js

Issue 594403004: history: fix tappable blank space at the end of history entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/history/history.js
diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js
index 0f285966adf808ef26d31ec336be8e2068b9b8bc..52dfbec92f400c57021837ff88940d3852a61ca0 100644
--- a/chrome/browser/resources/history/history.js
+++ b/chrome/browser/resources/history/history.js
@@ -207,8 +207,10 @@ Visit.prototype.getResultDOM = function(propertyBag) {
// Clicking anywhere in the entryBox will check/uncheck the checkbox.
entryBox.setAttribute('for', checkbox.id);
Evan Stade 2014/09/25 01:53:27 NOOOOOOOOOOO kill for!!
Dan Beam 2014/09/25 03:59:45 Acknowledged.
entryBox.addEventListener('mousedown', entryBoxMousedown);
Evan Stade 2014/09/25 01:53:26 i feel like all of these should go in the if block
Dan Beam 2014/09/25 03:59:45 Done.
- entryBox.addEventListener('click', entryBoxClick);
entryBox.addEventListener('keydown', this.handleKeydown_.bind(this));
+
+ if (!isMobileVersion())
+ entryBox.addEventListener('click', entryBoxClick);
}
// Keep track of the drop down that triggered the menu, so we know
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698