Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(532)

Side by Side Diff: chrome/browser/resources/history/history.js

Issue 594403004: history: fix tappable blank space at the end of history entries. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="../uber/uber_utils.js"> 5 <include src="../uber/uber_utils.js">
6 <include src="history_focus_manager.js"> 6 <include src="history_focus_manager.js">
7 7
8 /////////////////////////////////////////////////////////////////////////////// 8 ///////////////////////////////////////////////////////////////////////////////
9 // Globals: 9 // Globals:
10 /** @const */ var RESULTS_PER_PAGE = 150; 10 /** @const */ var RESULTS_PER_PAGE = 150;
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 checkbox.type = 'checkbox'; 197 checkbox.type = 'checkbox';
198 checkbox.id = 'checkbox-' + this.id_; 198 checkbox.id = 'checkbox-' + this.id_;
199 checkbox.time = this.date.getTime(); 199 checkbox.time = this.date.getTime();
200 checkbox.addEventListener('click', checkboxClicked); 200 checkbox.addEventListener('click', checkboxClicked);
201 time.setAttribute('for', checkbox.id); 201 time.setAttribute('for', checkbox.id);
202 entryBox.appendChild(checkbox); 202 entryBox.appendChild(checkbox);
203 203
204 if (focusless) 204 if (focusless)
205 checkbox.tabIndex = -1; 205 checkbox.tabIndex = -1;
206 206
207 // Clicking anywhere in the entryBox will check/uncheck the checkbox. 207 if (!isMobileVersion()) {
208 entryBox.setAttribute('for', checkbox.id); 208 // Clicking anywhere in the entryBox will check/uncheck the checkbox.
209 entryBox.addEventListener('mousedown', entryBoxMousedown); 209 entryBox.setAttribute('for', checkbox.id);
210 entryBox.addEventListener('click', entryBoxClick); 210 entryBox.addEventListener('mousedown', entryBoxMousedown);
211 entryBox.addEventListener('keydown', this.handleKeydown_.bind(this)); 211 entryBox.addEventListener('click', entryBoxClick);
212 entryBox.addEventListener('keydown', this.handleKeydown_.bind(this));
213 }
212 } 214 }
213 215
214 // Keep track of the drop down that triggered the menu, so we know 216 // Keep track of the drop down that triggered the menu, so we know
215 // which element to apply the command to. 217 // which element to apply the command to.
216 // TODO(dubroy): Ideally we'd use 'activate', but MenuButton swallows it. 218 // TODO(dubroy): Ideally we'd use 'activate', but MenuButton swallows it.
217 var setActiveVisit = function(e) { 219 var setActiveVisit = function(e) {
218 activeVisit = self; 220 activeVisit = self;
219 var menu = $('action-menu'); 221 var menu = $('action-menu');
220 menu.dataset.devicename = self.deviceName; 222 menu.dataset.devicename = self.deviceName;
221 menu.dataset.devicetype = self.deviceType; 223 menu.dataset.devicetype = self.deviceType;
(...skipping 2044 matching lines...) Expand 10 before | Expand all | Expand 10 after
2266 historyView.reload(); 2268 historyView.reload();
2267 } 2269 }
2268 2270
2269 // Add handlers to HTML elements. 2271 // Add handlers to HTML elements.
2270 document.addEventListener('DOMContentLoaded', load); 2272 document.addEventListener('DOMContentLoaded', load);
2271 2273
2272 // This event lets us enable and disable menu items before the menu is shown. 2274 // This event lets us enable and disable menu items before the menu is shown.
2273 document.addEventListener('canExecute', function(e) { 2275 document.addEventListener('canExecute', function(e) {
2274 e.canExecute = true; 2276 e.canExecute = true;
2275 }); 2277 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698