history: fix tappable blank space at the end of history entries.

history: fix tappable blank space at the end of history entries.

R=estade@chromium.org
BUG=407539
Committed: https://crrev.com/94d0c1bb01e98f35043ba1d170049a2e10818b59
Cr-Commit-Position: refs/heads/master@{#296650}

[Evan Stade, 2014-09-24 21:14:58]

I'm not sure I don't prefer the new behavior, so I wouldn't worry about landing
this fix right away and merging. Instead, just ping a designer, and make the
change if necessary, but don't bother to merge.

[Dan Beam, 2014-09-25 01:37:51]

On 2014/09/24 21:14:58, Evan Stade wrote:
> I'm not sure I don't prefer the new behavior, so I wouldn't worry about
landing
> this fix right away and merging. Instead, just ping a designer, and make the
> change if necessary, but don't bother to merge.

rolfe@ (designer) says this is the desired behavior

[Evan Stade, 2014-09-25 01:53:27]

https://codereview.chromium.org/594403004/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/594403004/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:208: entryBox.setAttribute('for',
checkbox.id);
NOOOOOOOOOOO

kill for!!

https://codereview.chromium.org/594403004/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:209:
entryBox.addEventListener('mousedown', entryBoxMousedown);
i feel like all of these should go in the if block (it's actually possible to
have a keyboard on an android device, in case you're wondering)

[Dan Beam, 2014-09-25 03:59:45]

https://codereview.chromium.org/594403004/diff/1/chrome/browser/resources/his...
File chrome/browser/resources/history/history.js (right):

https://codereview.chromium.org/594403004/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:208: entryBox.setAttribute('for',
checkbox.id);
On 2014/09/25 01:53:27, Evan Stade wrote:
> NOOOOOOOOOOO
> 
> kill for!!

Acknowledged.

https://codereview.chromium.org/594403004/diff/1/chrome/browser/resources/his...
chrome/browser/resources/history/history.js:209:
entryBox.addEventListener('mousedown', entryBoxMousedown);
On 2014/09/25 01:53:26, Evan Stade wrote:
> i feel like all of these should go in the if block (it's actually possible to
> have a keyboard on an android device, in case you're wondering)

Done.

[Evan Stade, 2014-09-25 04:09:46]

lgtm

[Dan Beam, 2014-09-25 04:22:51]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-25 04:23:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/594403004/40001

[commit-bot: I haz the power, 2014-09-25 05:05:00]

Committed patchset #3 (id:40001) as c1cae9326a40336949d8b40aa173dc5e0c8feeb7

[commit-bot: I haz the power, 2014-09-25 05:05:41]

Patchset 3 (id:??) landed as
https://crrev.com/94d0c1bb01e98f35043ba1d170049a2e10818b59
Cr-Commit-Position: refs/heads/master@{#296650}