Add net::HttpServer::Delegate::OnConnect() function and set ChromeDriver buffer sizes to 100 MB

chrome/test/chromedriver/net/test_http_server.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/net/test_http_server.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop.h"
 #include "base/message_loop/message_loop_proxy.h"
@@ skipping 57 matching lines @@
 void TestHttpServer::SetMessageAction(WebSocketMessageAction action) {
   base::AutoLock lock(action_lock_);
   message_action_ = action;
 }
 
 GURL TestHttpServer::web_socket_url() const {
   base::AutoLock lock(url_lock_);
   return web_socket_url_;
 }
 
-void TestHttpServer::OnHttpRequest(
-    int connection_id,
-    const net::HttpServerRequestInfo& info) {
+void TestHttpServer::OnConnect(int connection_id) {
   server_->SetSendBufferSize(connection_id, kBufferSize);
   server_->SetReceiveBufferSize(connection_id, kBufferSize);
 }
 
 void TestHttpServer::OnWebSocketRequest(
     int connection_id,
     const net::HttpServerRequestInfo& info) {
   server_->SetSendBufferSize(connection_id, kBufferSize);

[stgao, 2014/09/24 17:53:34]

Could these two lines be deleted as they are already set in OnConnect above?

[samuong, 2014/09/24 18:18:35]

Done.

   server_->SetReceiveBufferSize(connection_id, kBufferSize);
 
   WebSocketRequestAction action;
   {
     base::AutoLock lock(action_lock_);
     action = request_action_;
   }
   connections_.insert(connection_id);
   all_closed_event_.Reset();
 
   switch (action) {
     case kAccept:
       server_->AcceptWebSocket(connection_id, info);
       break;
     case kNotFound:
       server_->Send404(connection_id);
       break;
     case kClose:
       server_->Close(connection_id);
       break;
   }
 }
 
 void TestHttpServer::OnWebSocketMessage(int connection_id,
                                         const std::string& data) {
   server_->SetSendBufferSize(connection_id, kBufferSize);

[stgao, 2014/09/24 17:53:34]

Same here.

[samuong, 2014/09/24 18:18:35]

Done.

   server_->SetReceiveBufferSize(connection_id, kBufferSize);
   WebSocketMessageAction action;
   {
     base::AutoLock lock(action_lock_);
     action = message_action_;
   }
   switch (action) {
     case kEchoMessage:
       server_->SendOverWebSocket(connection_id, data);
       break;
@@ skipping 27 matching lines @@
     server_.reset(NULL);
   }
   *success = server_.get();
   event->Signal();
 }
 
 void TestHttpServer::StopOnServerThread(base::WaitableEvent* event) {
   server_.reset(NULL);
   event->Signal();
 }