Add net::HttpServer::Delegate::OnConnect() function and set ChromeDriver buffer sizes to 100 MB

net/server/http_server_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 171 matching lines @@
   HttpServerTest() : quit_after_request_count_(0) {}
 
   virtual void SetUp() OVERRIDE {
     scoped_ptr<ServerSocket> server_socket(
         new TCPServerSocket(NULL, net::NetLog::Source()));
     server_socket->ListenWithAddressAndPort("127.0.0.1", 0, 1);
     server_.reset(new HttpServer(server_socket.Pass(), this));
     ASSERT_EQ(OK, server_->GetLocalAddress(&server_address_));
   }
 
+  virtual void OnConnect(int connection_id) OVERRIDE {}
+
   virtual void OnHttpRequest(int connection_id,
                              const HttpServerRequestInfo& info) OVERRIDE {
     requests_.push_back(std::make_pair(info, connection_id));
     if (requests_.size() == quit_after_request_count_)
       run_loop_quit_func_.Run();
   }
 
   virtual void OnWebSocketRequest(int connection_id,
                                   const HttpServerRequestInfo& info) OVERRIDE {
     NOTREACHED();
@@ skipping 410 matching lines @@
   ASSERT_EQ("/test3", GetRequest(2).path);
 
   ASSERT_EQ(client_connection_id, GetConnectionId(2));
   server_->Send200(client_connection_id, "Content for /test3", "text/plain");
   std::string response3;
   ASSERT_TRUE(client.ReadResponse(&response3));
   ASSERT_TRUE(StartsWithASCII(response3, "HTTP/1.1 200 OK", true));
   ASSERT_TRUE(EndsWith(response3, "Content for /test3", true));
 }
 
+namespace {

[mmenke, 2014/09/24 15:38:45]

nit:  Can you just stick this entire file in the anonymous namespace instead?

[samuong, 2014/09/24 16:32:51]

I've done this as much as possible, but HttpServerTest is a friend class of
net::HttpServer, so it needs to be outside of the anonymous namespace for the
friend declaration in net::HttpServer to work. But everything else in this file
is now in an anonymous namespace.

+
+class CloseOnConnectHttpServerTest : public HttpServerTest {
+ public:
+  virtual void OnConnect(int connection_id) OVERRIDE {
+    connection_ids_.push_back(connection_id);
+    server_->Close(connection_id);
+  }
+
+ protected:
+  std::vector<int> connection_ids_;
+};
+
+} // namespace

[mmenke, 2014/09/24 15:38:45]

nit: 2 spaces between code and comment.

[samuong, 2014/09/24 16:32:51]

Done.

+
+TEST_F(CloseOnConnectHttpServerTest, ServerImmediatelyClosesConnection) {
+  TestHttpClient client;
+  ASSERT_EQ(OK, client.ConnectAndWait(server_address_));
+  ASSERT_EQ(1ul, connection_ids_.size());
+  client.Send("GET / HTTP/1.1\r\n\r\n");
+  ASSERT_FALSE(RunUntilRequestsReceived(1));
+  ASSERT_EQ(0ul, requests_.size());
+}
+
 }  // namespace net