Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 594383005: [ChromeDriver] Detect page loading status when the page is not loaded at all. (Closed)

Created:
6 years, 3 months ago by stgao
Modified:
6 years, 2 months ago
Reviewers:
samuong
CC:
chromium-reviews, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[ChromeDriver] Detect page loading status when the page is not loaded at all. BUG=chromedriver:815 Committed: https://crrev.com/af41684421a077cb0d3f87c904de83ce13423b47 Cr-Commit-Position: refs/heads/master@{#297468}

Patch Set 1 : . #

Patch Set 2 : Add a new unittest and fix existing unittest. #

Total comments: 2

Patch Set 3 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -11 lines) Patch
M chrome/test/chromedriver/chrome/navigation_tracker.cc View 3 chunks +23 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc View 1 2 8 chunks +41 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/test/run_py_tests.py View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
stgao
6 years, 2 months ago (2014-09-26 20:39:12 UTC) #4
samuong
Thanks Shuotao. This breaks a few of the unit tests for me, does this happen ...
6 years, 2 months ago (2014-09-29 17:20:32 UTC) #5
stgao
Added a new unittest and fixed existing unittest.
6 years, 2 months ago (2014-09-30 00:08:28 UTC) #6
samuong
On 2014/09/30 00:08:28, Shuotao wrote: > Added a new unittest and fixed existing unittest. thanks, ...
6 years, 2 months ago (2014-09-30 04:37:10 UTC) #7
samuong
https://codereview.chromium.org/594383005/diff/60001/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc File chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc (right): https://codereview.chromium.org/594383005/diff/60001/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc#newcode316 chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc:316: if (has_empty_base_url_) { remove braces?
6 years, 2 months ago (2014-09-30 04:37:17 UTC) #8
stgao
https://codereview.chromium.org/594383005/diff/60001/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc File chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc (right): https://codereview.chromium.org/594383005/diff/60001/chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc#newcode316 chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc:316: if (has_empty_base_url_) { On 2014/09/30 04:37:17, samuong wrote: > ...
6 years, 2 months ago (2014-09-30 17:57:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594383005/80001
6 years, 2 months ago (2014-09-30 17:59:08 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:80001) as b33fbf9958ff11e6b28d3803123bf488af48ce14
6 years, 2 months ago (2014-09-30 18:57:36 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-09-30 18:58:45 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/af41684421a077cb0d3f87c904de83ce13423b47
Cr-Commit-Position: refs/heads/master@{#297468}

Powered by Google App Engine
This is Rietveld 408576698