Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2606)

Unified Diff: ash/wm/workspace/workspace_layout_manager.cc

Issue 594383002: Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event
Patch Set: Address varkha's comments in #7 Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/workspace/workspace_layout_manager.cc
diff --git a/ash/wm/workspace/workspace_layout_manager.cc b/ash/wm/workspace/workspace_layout_manager.cc
index 63c4aed0e71112d817c63f2d2bd71d113efe85f6..4d7a36dbc3c0b7c2c24d7fb19f6cbdc4b6d6356b 100644
--- a/ash/wm/workspace/workspace_layout_manager.cc
+++ b/ash/wm/workspace/workspace_layout_manager.cc
@@ -264,6 +264,9 @@ void WorkspaceLayoutManager::OnPostWindowStateTypeChange(
wm::WindowState* window_state,
wm::WindowStateType old_type) {
+ if (window_state->IsDocked())
+ wm::DockWindow(window_state->window());
varkha 2014/10/01 19:08:51 I assume this can never get called when the window
dtapuska 2014/10/01 20:17:42 No I don't believe so. The listeners are removed w
+
// Notify observers that fullscreen state may be changing.
if (window_state->IsFullscreen() ||
old_type == wm::WINDOW_STATE_TYPE_FULLSCREEN) {

Powered by Google App Engine
This is Rietveld 408576698