ash/accelerators/accelerator_controller_unittest.cc - Issue 594383002: Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/accelerators/accelerator_controller_unittest.cc

Issue 594383002: Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@event

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« ash/accelerators/accelerator_controller.cc ('K') | « ash/accelerators/accelerator_controller.cc ('k') | ash/accelerators/accelerator_table.h » ('j') | ash/wm/panels/panel_layout_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/accelerators/accelerator_controller_unittest.cc

diff --git a/ash/accelerators/accelerator_controller_unittest.cc b/ash/accelerators/accelerator_controller_unittest.cc

index 31ebf9b4e41372d262315ef9e27db36153c2af10..4a94aabd90b29d8bca07641afd409219cbdc2e67 100644

--- a/ash/accelerators/accelerator_controller_unittest.cc

+++ b/ash/accelerators/accelerator_controller_unittest.cc

@@ -432,13 +432,13 @@ TEST_F(AcceleratorControllerTest, WindowSnap) {

window_state->Activate();

{

- GetController()->PerformAction(WINDOW_SNAP_LEFT, dummy);

+ GetController()->PerformAction(WINDOW_SNAP_OR_DOCK_LEFT, dummy);

gfx::Rect expected_bounds = wm::GetDefaultLeftSnappedWindowBoundsInParent(

window.get());

EXPECT_EQ(expected_bounds.ToString(), window->bounds().ToString());

}

{

- GetController()->PerformAction(WINDOW_SNAP_RIGHT, dummy);

+ GetController()->PerformAction(WINDOW_SNAP_OR_DOCK_RIGHT, dummy);

gfx::Rect expected_bounds = wm::GetDefaultRightSnappedWindowBoundsInParent(

window.get());

EXPECT_EQ(expected_bounds.ToString(), window->bounds().ToString());

@@ -457,11 +457,11 @@ TEST_F(AcceleratorControllerTest, WindowSnap) {

EXPECT_EQ(normal_bounds.ToString(), window->bounds().ToString());

GetController()->PerformAction(TOGGLE_MAXIMIZED, dummy);

- GetController()->PerformAction(WINDOW_SNAP_LEFT, dummy);

+ GetController()->PerformAction(WINDOW_SNAP_OR_DOCK_LEFT, dummy);

EXPECT_FALSE(window_state->IsMaximized());

GetController()->PerformAction(TOGGLE_MAXIMIZED, dummy);

- GetController()->PerformAction(WINDOW_SNAP_RIGHT, dummy);

+ GetController()->PerformAction(WINDOW_SNAP_OR_DOCK_RIGHT, dummy);

EXPECT_FALSE(window_state->IsMaximized());

GetController()->PerformAction(TOGGLE_MAXIMIZED, dummy);