Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe…

ash/wm/panels/panel_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/panels/panel_layout_manager.h"
 
 #include <algorithm>
 #include <map>
 
 #include "ash/screen_util.h"
@@ skipping 469 matching lines @@
   if (key == kShelfID)
     Relayout();
 }
 
 /////////////////////////////////////////////////////////////////////////////
 // PanelLayoutManager, WindowStateObserver implementation:
 
 void PanelLayoutManager::OnPostWindowStateTypeChange(
     wm::WindowState* window_state,
     wm::WindowStateType old_type) {
-  // If the shelf is currently hidden then windows will not actually be shown
-  // but the set to restore when the shelf becomes visible is updated.
-  if (restore_windows_on_shelf_visible_) {
-    if (window_state->IsMinimized()) {
+  aura::Window* window = window_state->window();

[varkha, 2014/09/29 21:04:34]

Since you have this you could s/'window_state->window()'/'window' below.

[dtapuska, 2014/09/30 14:40:49]

Done.

+  if (window_state->IsDocked()) {
+    wm::DockWindow(window);

[varkha, 2014/09/29 21:04:34]

Just a question - is this what allows the accelerator to work on panels or do
you need it for some other reason?

[dtapuska, 2014/09/30 14:40:49]

Yes; a panel is in the panel layout manager; and it changes to Docked state;
this removes it from the panel layout manager and adds it to the
DockedLayoutManager (it does the reparenting; the wm::DockWindow(...)

+  } else {
+    // If the shelf is currently hidden then windows will not actually be shown
+    // but the set to restore when the shelf becomes visible is updated.
+    if (restore_windows_on_shelf_visible_) {
+      if (window_state->IsMinimized()) {
+        MinimizePanel(window_state->window());
+        restore_windows_on_shelf_visible_->Remove(window_state->window());
+      } else {
+        restore_windows_on_shelf_visible_->Add(window_state->window());
+      }
+      return;
+    }
+
+    if (window_state->IsMinimized())
       MinimizePanel(window_state->window());
-      restore_windows_on_shelf_visible_->Remove(window_state->window());
-    } else {
-      restore_windows_on_shelf_visible_->Add(window_state->window());
-    }
-    return;
+    else
+      RestorePanel(window_state->window());
   }
-
-  if (window_state->IsMinimized())
-    MinimizePanel(window_state->window());
-  else
-    RestorePanel(window_state->window());
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // PanelLayoutManager, aura::client::ActivationChangeObserver implementation:
 
 void PanelLayoutManager::OnWindowActivated(aura::Window* gained_active,
                                            aura::Window* lost_active) {
   // Ignore if the panel that is not managed by this was activated.
   if (gained_active && gained_active->type() == ui::wm::WINDOW_TYPE_PANEL &&
       gained_active->parent() == panel_container_) {
@@ skipping 420 matching lines @@
       // Keyboard hidden, restore original bounds if they exist.
       SetChildBounds(panel, panel_state->GetRestoreBoundsInScreen());
     }
   }
   // This bounds change will have caused a change to the Shelf which does not
   // propogate automatically to this class, so manually recalculate bounds.
   OnWindowResized();
 }
 
 }  // namespace ash