Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe…

ash/accelerators/accelerator_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/accelerators/accelerator_controller.h"
 
 #include <algorithm>
 #include <cmath>
 #include <string>
 
@@ skipping 484 matching lines @@
   }
   accelerators::ToggleFullscreen();
   return true;
 }
 
 bool HandleToggleRootWindowFullScreen() {
   Shell::GetPrimaryRootWindowController()->ash_host()->ToggleFullScreen();
   return true;
 }
 
-bool HandleWindowSnap(int action) {
+bool HandleWindowSnapOrDock(int action) {
   wm::WindowState* window_state = wm::GetActiveWindowState();
   // Disable window snapping shortcut key for full screen window due to
   // http://crbug.com/135487.
   if (!window_state ||
-      window_state->window()->type() != ui::wm::WINDOW_TYPE_NORMAL ||
-      window_state->IsFullscreen() ||
-      !window_state->CanSnap()) {
+      (window_state->window()->type() != ui::wm::WINDOW_TYPE_NORMAL &&
+      window_state->window()->type() != ui::wm::WINDOW_TYPE_PANEL) ||
+      window_state->IsFullscreen()) {
     return false;
   }
 
-  if (action == WINDOW_SNAP_LEFT) {
+  if (action == WINDOW_CYCLE_SNAP_DOCK_LEFT)
     base::RecordAction(UserMetricsAction("Accel_Window_Snap_Left"));
-  } else {
+  else
     base::RecordAction(UserMetricsAction("Accel_Window_Snap_Right"));
-  }
-  const wm::WMEvent event(action == WINDOW_SNAP_LEFT ?
-                          wm::WM_EVENT_SNAP_LEFT : wm::WM_EVENT_SNAP_RIGHT);
+
+  const wm::WMEvent event(action == WINDOW_CYCLE_SNAP_DOCK_LEFT ?
+                          wm::WM_EVENT_CYCLE_SNAP_DOCK_LEFT :
+                          wm::WM_EVENT_CYCLE_SNAP_DOCK_RIGHT);
   window_state->OnWMEvent(&event);
   return true;
 }
 
 bool HandleWindowMinimize() {
   base::RecordAction(
       base::UserMetricsAction("Accel_Toggle_Minimized_Minus"));
   return accelerators::ToggleMinimized();
 }
 
@@ skipping 511 matching lines @@
     case LAUNCH_APP_4:
       return HandleLaunchAppN(4);
     case LAUNCH_APP_5:
       return HandleLaunchAppN(5);
     case LAUNCH_APP_6:
       return HandleLaunchAppN(6);
     case LAUNCH_APP_7:
       return HandleLaunchAppN(7);
     case LAUNCH_LAST_APP:
       return HandleLaunchLastApp();
-    case WINDOW_SNAP_LEFT:
-    case WINDOW_SNAP_RIGHT:
-      return HandleWindowSnap(action);
+    case WINDOW_CYCLE_SNAP_DOCK_LEFT:
+    case WINDOW_CYCLE_SNAP_DOCK_RIGHT:
+      return HandleWindowSnapOrDock(action);
     case WINDOW_MINIMIZE:
       return HandleWindowMinimize();
     case TOGGLE_FULLSCREEN:
       return HandleToggleFullscreen(key_code);
     case TOGGLE_MAXIMIZED:
       accelerators::ToggleMaximized();
       return true;
     case WINDOW_POSITION_CENTER:
      return HandlePositionCenter();
     case SCALE_UI_UP:
@@ skipping 150 matching lines @@
     keyboard_brightness_control_delegate) {
   keyboard_brightness_control_delegate_ =
       keyboard_brightness_control_delegate.Pass();
 }
 
 bool AcceleratorController::CanHandleAccelerators() const {
   return true;
 }
 
 }  // namespace ash