Change behaviour of the Alt-] and Alt-[ keys so that it cycles through SnapLeft/SnapRight to DockLe…

ash/wm/panels/panel_layout_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/wm/panels/panel_layout_manager.h"
 
 #include <algorithm>
 #include <map>
 
 #include "ash/screen_util.h"
@@ skipping 466 matching lines @@
                                                  intptr_t old) {
   // Trigger a relayout to position the panels whenever the panel icon is set
   // or changes.
   if (key == kShelfID)
     Relayout();
 }
 
 /////////////////////////////////////////////////////////////////////////////
 // PanelLayoutManager, WindowStateObserver implementation:
 
+void PanelLayoutManager::OnPreWindowStateTypeChange(

[varkha, 2014/09/24 03:16:23]

Would be nice to move this into some place that is more dock-aware.

[dtapuska, 2014/09/25 23:27:09]

I collapsed the moving code; but the state management needs to be done here. We
have a panel layout and a window now has become docked so we need to re-parent
it.

+    wm::WindowState* window_state,
+    wm::WindowStateType old_type) {
+  aura::Window* window = window_state->window();
+  if (window_state->IsDocked()) {
+    // Reparent the window into the docked windows container in order to get it
+    // on top of other docked windows.
+    aura::Window* docked_container = Shell::GetContainer(
+        window->GetRootWindow(),
+        kShellWindowId_DockedContainer);
+    wm::ReparentChildWithTransientChildren(window,
+                                           window->parent(),
+                                           docked_container);
+  }
+}
+
 void PanelLayoutManager::OnPostWindowStateTypeChange(
     wm::WindowState* window_state,
     wm::WindowStateType old_type) {
   // If the shelf is currently hidden then windows will not actually be shown
   // but the set to restore when the shelf becomes visible is updated.
   if (restore_windows_on_shelf_visible_) {
     if (window_state->IsMinimized()) {
       MinimizePanel(window_state->window());
       restore_windows_on_shelf_visible_->Remove(window_state->window());
     } else {
@@ skipping 435 matching lines @@
       // Keyboard hidden, restore original bounds if they exist.
       SetChildBounds(panel, panel_state->GetRestoreBoundsInScreen());
     }
   }
   // This bounds change will have caused a change to the Shelf which does not
   // propogate automatically to this class, so manually recalculate bounds.
   OnWindowResized();
 }
 
 }  // namespace ash