Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 594373002: Prevent updateOpenCommand() from receiving e.target of type other than BookmarkList|BookmarkTree (Closed)

Created:
6 years, 3 months ago by Vitaly Pavlenko
Modified:
6 years, 3 months ago
CC:
chromium-reviews, tfarina, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Prevent updateOpenCommand() from receiving e.target of type other than BookmarkList|BookmarkTree R=arv@chromium.org BUG=393873 Committed: https://crrev.com/0106c710b9478ae679274e90be3fbce3623632c2 Cr-Commit-Position: refs/heads/master@{#296456}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/resources/bookmark_manager/js/main.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Vitaly Pavlenko
6 years, 3 months ago (2014-09-23 21:07:55 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 3 months ago (2014-09-24 15:13:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594373002/1
6 years, 3 months ago (2014-09-24 16:53:58 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 71389623a91be3c312210effa89ec577f267f261
6 years, 3 months ago (2014-09-24 17:54:32 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 17:55:08 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0106c710b9478ae679274e90be3fbce3623632c2
Cr-Commit-Position: refs/heads/master@{#296456}

Powered by Google App Engine
This is Rietveld 408576698