Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 594363003: Make pictures in multipicturedraw GM fit in 0,0..W,H range (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Make pictures in multipicturedraw GM fit in 0,0..W,H range Having the picture contents not actually reside in the 0,0..W,H range wrecks havoc with the layer hoisting. The hoisting works correctly but since the picture don't fulfill their contract the results look incorrect. This CL just translates the picture's contents to the right so they are within the picture bound. Committed: https://skia.googlesource.com/skia/+/aa0c837667306babf7dc284c1b8da77127b993a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M gm/multipicturedraw.cpp View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
robertphillips
6 years, 2 months ago (2014-09-26 15:30:08 UTC) #2
egdaniel
lgtm
6 years, 2 months ago (2014-09-26 16:57:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/594363003/1
6 years, 2 months ago (2014-09-29 11:59:48 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-09-29 12:07:41 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as aa0c837667306babf7dc284c1b8da77127b993a1

Powered by Google App Engine
This is Rietveld 408576698